1864941 - Investigate if a browser_glean_telemetry_abandonment_tips.js test in the Search and Address Bar needs to be updated to pass a11y_checks

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Anna Yeddi [:ayeddi] ⚠️ Online half days through May 23]

It appears that browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_tips.js tests not user-facing behavior: the test cases are sending a click event somewhere on the window to test that the tooltip would, in fact, disappear or not (depending on the test case), while there are other ways to dismiss the tooltip that are accessible (i.e. by pressing Esc key).

This is not expected or does not have to be done by a user of an assistive technology and it does not have to confirm the accessibility of this element.

We may need to add an exception from a11y_checks for these clicks, because the click is not meant to be interactive and is not expected to be accessible. Thus, we are excluding this click event from accessibility checks and removing the fail-if notation that was added by bug 1854660 before the investigation in the meta bug 1854661.

a11y_checks failing data:

FAIL	browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_tips.js	Node is not accessible via accessibility API		browser		"
chrome://mochikit/content/browser-test.js:test_ok:1583
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:339
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:658
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:635
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleClick:751
chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouseAtPoint:652
chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouse:555
chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouseAtCenter:740
chrome://mochitests/content/browser/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_tips.js:mouse_down_with_tip/</<:61
resource://testing-common/UrlbarTestUtils.sys.mjs:promisePopupClose:733
chrome://mochitests/content/browser/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_tips.js:mouse_down_with_tip/<:60
resource://testing-common/BrowserTestUtils.sys.mjs:withNewTab:146
chrome://mochitests/content/browser/browser/components/urlbar/tests/engagementTelemetry/browser/head.js:doTest:219
chrome://mochitests/content/browser/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_tips.js:mouse_down_with_tip:58
chrome://mochikit/content/browser-test.js:handleTask:1134
chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1206
chrome://mochikit/content/browser-test.js:Tester_execTest:1348
chrome://mochikit/content/browser-test.js:nextTest/<:1123
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058"

Comment 1

[Anna Yeddi [:ayeddi] ⚠️ Online half days through May 23]

Attachment: Bug 1864941 - Add exceptions from a11y_checks for 3 tests clicking outside of the urlbar in Search and Address Bar. r=Jamie

It appears that browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_tips.js tests not user-facing behavior: the test cases are sending a click event somewhere on the window to test that the tooltip would, in fact, disappear or not (depending on the test case), while there are other ways to dismiss the tooltip that are accessible (i.e. by pressing Esc key).

This is not expected or does not have to be done by a user of an assistive technology and it does not have to confirm the accessibility of this element.

We may need to add an exception from a11y_checks for these clicks, because the click is not meant to be interactive and is not expected to be accessible. Thus, we are excluding this click event from accessibility checks and removing the fail-if notation that was added by bug 1854660 before the investigation in the meta bug 1854661.

Comment 2

[Anna Yeddi [:ayeddi] ⚠️ Online half days through May 23]

Similar behavior approach appears to be used in the browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_edge_cases.js where both Escape key and click on a static element (<toolbarspring> which is an empty space in chrome with no interaction expected) are tested.

FAIL	browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_edge_cases.js	Node is not accessible via accessibility API	customizableui-special-spring2	toolbarspring	chromeclass-toolbar-additional	"
chrome://mochikit/content/browser-test.js:test_ok:1583
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:339
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:658
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:635
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleClick:751
chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouseAtPoint:652
chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouse:555
chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouseAtCenter:740
chrome://mochitests/content/browser/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_edge_cases.js:engagement_after_closing_results/TRIGGERS<:154
chrome://mochitests/content/browser/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_edge_cases.js:engagement_after_closing_results/</<:164
resource://testing-common/UrlbarTestUtils.sys.mjs:promisePopupClose:733
chrome://mochitests/content/browser/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_edge_cases.js:engagement_after_closing_results/<:163
resource://testing-common/BrowserTestUtils.sys.mjs:withNewTab:146
chrome://mochitests/content/browser/browser/components/urlbar/tests/engagementTelemetry/browser/head.js:doTest:219
chrome://mochitests/content/browser/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_edge_cases.js:engagement_after_closing_results:161
chrome://mochikit/content/browser-test.js:handleTask:1134
chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1206
chrome://mochikit/content/browser-test.js:Tester_execTest:1348
chrome://mochikit/content/browser-test.js:nextTest/<:1123
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
"```

Comment 3

[Anna Yeddi [:ayeddi] ⚠️ Online half days through May 23]

Another tests are in the file browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js - note the file also has failed label check (see a11y_checks_labeled):

FAIL
browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js
Node is not accessible via accessibility API	
html:body		"
chrome://mochikit/content/browser-test.js:test_ok:1583
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:339
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:658
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:635
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleClick:751
chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouseAtPoint:621
chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouse:555
chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouseAtCenter:740
chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js:basic/<:103
resource://testing-common/BrowserTestUtils.sys.mjs:withNewTab:146
chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js:basic:85
"
FAIL	
browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js
Node is not accessible via accessibility API	
browser		"
chrome://mochikit/content/browser-test.js:test_ok:1583
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:339
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:658
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:635
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleClick:751
chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouseAtPoint:621
chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouse:555
chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouseAtCenter:740
chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js:withSelectionByKeyboard/<:269
resource://testing-common/BrowserTestUtils.sys.mjs:withNewTab:146
chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js:withSelectionByKeyboard:223

Comment 4

[Mark Banner (:standard8)]

Just to note the urlbar tests normally go under Address Bar. You can check this in searchfox or ./mach file-info bugzilla-component path/to/file.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a599fccaab14
Add exceptions from a11y_checks for 3 tests clicking outside of the urlbar in Search and Address Bar. r=adw

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a599fccaab14