1874557 - Regression of bug 1846336: Tag pref observer not registered if automatic updates are not enabled

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[betterbird.project+13]

This line was added into a block that is only executed when automatic updates are enabled:

https://hg.mozilla.org/releases/comm-esr115/rev/719382879ac7#l2.12

This will affect builds which don't have automatic updates enabled.

Comment 1

[betterbird.project+13]

https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1874557-fix-tag-observer.patch

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1874557 - Add observer for 'mailnews.tags.' correctly - not only inside an MOZ_UPDATER block. r=#thunderbird-reviewers

Based on https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1874557-fix-tag-observer.patch

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/20aea3121ae0
Add observer for 'mailnews.tags.' correctly - not only inside an MOZ_UPDATER block. r=john.bieling

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9377605 [details]
Bug 1874557 - Add observer for 'mailnews.tags.' correctly - not only inside an MOZ_UPDATER block. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1846336
User impact if declined: tag updates not noticed, if no updater is compiled in
Testing completed (on c-c, etc.): c-c, beta
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9377605 [details]
Bug 1874557 - Add observer for 'mailnews.tags.' correctly - not only inside an MOZ_UPDATER block. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 115.8.1:
https://hg.mozilla.org/releases/comm-esr115/rev/c7b34157c75e