1874663 - [HCM] Visibility and Hover Effect Issues with "Save" Buttons on Windows

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect, P1)

Description

[Simona Badau, Desktop QA]

Attachment: Save buttons in HCM

Found in

• Nightly 123.0a1

Affected versions

• Nightly 123.0a1

Tested platforms

• Affected platforms: Windows 10 x64

Preconditions

• 'screenshots.browser.component.enabled' is set to true in about:config
• High Contrast Mode is enabled with the default Firefox theme - System theme auto.

Steps to reproduce

1. Navigate to any website and enable Screenshots.
2. Hover your mouse over the "Save visible" and "Save full page" buttons.

Expected result

• "Save visible" and "Save full page" buttons should be visible and have a mouse hover effect while in High Contrast Mode.

Actual result

• The text of the "Save" buttons is not visible and the buttons do not have a hover effect.

Regression range

• This is not a regression, it's reproducible only when enabling the component version of Screenshots.

Additional notes

• On High Contrast White and on High Contrast #2 themes - the behavior is reproducible when the Firefox window is in focus.
• On High Contrast #1 theme - the behavior is reproducible when the Firefox window is out of focus.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:sbadau, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Sam Foster [:sfoster] (he/him)]

Looks like they changed HCM settings in Window 11 and I can't reproduce there.

Comment 3

[Anna Yeddi [:ayeddi]]

From the screenshot, the HCM styles are not provided to the buttons making them appearing as unlabeled and, considering the position and that this content is overlaying a web content, they may not be perceived by the users as controls at all.

We need to follow this set of system colors for buttons (NDAed link), which, on hover, would change to SelectedItem and SelectedItemText combination for both the background and foreground (border, icon, label)

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:sfoster, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 5

[Sam Foster [:sfoster] (he/him)]

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #4)

The severity field for this bug is set to S3. However, the accessibility severity is higher, .

I've bumped it to S2. Though this feature is behind a pref, when it becomes default S2 will likely apply.

Comment 6

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1874663 - Ensure panel buttons have a text color defined. r?niklas

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c9e933e43a3
Ensure panel buttons have a text color defined. r=niklas

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4c9e933e43a3

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sfoster, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Sam Foster [:sfoster] (he/him)]

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #9)

The patch landed in nightly and beta is affected.
:sfoster, is this bug important enough to require an uplift?

The feature is still behind a pref so I don't think uplift is necessary.

Comment 11

[Simona Badau, Desktop QA]

Verified as fixed using the latest Nightly 124.0a1 - the Save buttons are visible on Windows 10 x64.