1874717 - wayland proxy connection failure after applying update, defaulting to xwayland

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[:gerard-majax]

After applying update using our updater, I saw:

janv. 15 16:02:18 portable-alex Firefox-Nightly.desktop[841041]: Wayland Proxy error: ConnectToCompositor() connect() : Aucun fichier ou dossier de ce type
janv. 15 16:02:18 portable-alex Firefox-Nightly.desktop[841041]: Wayland Proxy error: StartProxyServer(): bind() error : Adresse déjà utilisée
janv. 15 16:02:18 portable-alex Firefox-Nightly.desktop[841041]: [GFX1-]: glxtest: Could not connect to wayland display, WAYLAND_DISPLAY=/run/user/1000/wayland-proxy-841041

PID 841041 is indeed the PID of the updated Firefox.

This makes the browser switch to XWayland that triggers all kind of weird bugs.

Comment 1

[:gerard-majax]

There's no /run/user/1000/wayland-proxy-841041 socket

Comment 2

[:gerard-majax]

Killing / restarting after the update was applied and the browser was restarted gets back pure Wayland connection, and /run/user/1000/wayland-proxy-852295 is there.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1743144

Comment 4

[Emilio Cobos Álvarez (:emilio)]

I guess when restarting we're somehow inheriting the WAYLAND_DISPLAY variable from our previous process...

Comment 5

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

I guess when restarting we're somehow inheriting the WAYLAND_DISPLAY variable from our previous process...

Yes, we don't terminate the proxy when restart after update.

Comment 6

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1874717 [Wayland] Clear Wayland proxy from LaunchChild() r?emilio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7e569a30426
[Wayland] Clear Wayland proxy from LaunchChild() r=emilio

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c7e569a30426