1874871 - Perma TEST-UNEXPECTED-PASS | /css/cssom-view/client-props-zoom.html | Client properties for elements with css zoom 1 - expected FAIL when Gecko 123 merges to Beta on 2024-01-22

Status: VERIFIED FIXED

(Core :: DOM: CSS Object Model, defect)

Description

[Iulian Moraru]

[Tracking Requested - why for this release]:

• Central-as-beta simulation.
• How to run these simulations.

Failure log:

[task 2024-01-16T12:26:33.436Z] 12:26:33     INFO - TEST-START | /css/cssom-view/client-props-zoom.html
[task 2024-01-16T12:26:33.452Z] 12:26:33     INFO - Closing window abd7bae6-b052-47b2-9959-d1c4f54cd4bb
[task 2024-01-16T12:26:33.862Z] 12:26:33     INFO - 
[task 2024-01-16T12:26:33.862Z] 12:26:33     INFO - TEST-PASS | /css/cssom-view/client-props-zoom.html | Client properties for elements with css zoom 
[task 2024-01-16T12:26:33.862Z] 12:26:33     INFO - TEST-UNEXPECTED-PASS | /css/cssom-view/client-props-zoom.html | Client properties for elements with css zoom 1 - expected FAIL
[task 2024-01-16T12:26:33.862Z] 12:26:33     INFO - TEST-INFO | expected FAIL
[task 2024-01-16T12:26:33.862Z] 12:26:33     INFO - TEST-OK | /css/cssom-view/client-props-zoom.html | took 426ms

Comment 1

[Iulian Moraru]

Hi James! Can you please take a look at this?
Thank you!

Comment 2

[Daniel Holbert [:dholbert]]

The Nightly-specific-ness here is probably just because this test is testing CSS zoom which we only support on Nightly, per this snippet:
https://searchfox.org/mozilla-central/rev/2fa4750e87d49ec7ad19fa1da167a03ef6d5e954/modules/libpref/init/StaticPrefList.yaml#8880-8885

# Support for the css Zoom property.
- name: layout.css.zoom.enabled
  type: RelaxedAtomicBool
  value: @IS_NIGHTLY_BUILD@
  mirror: always
  rust: true

We probably just need to explicitly enable the pref for this test like we do e.g. here for another test:
https://searchfox.org/mozilla-central/rev/2fa4750e87d49ec7ad19fa1da167a03ef6d5e954/testing/web-platform/meta/resize-observer/svg.html.ini#2

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: Bug 1874871: Enable the css zoom about:config pref, for WPT 'client-props-zoom.html'. r?#layout

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e6bdeec62c2
Enable the css zoom about:config pref, for WPT 'client-props-zoom.html'. r=TYLin

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0e6bdeec62c2

Comment 6

[Serban Stanca [:SerbanS]]

Hello Daniel! Could you please take another look at this as the patch is not working entirely in today's central as beta simulation?. The failure in client-props-zoom.html seems to have disappeared, but the others are still there

Thank you!

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1874310

Comment 8

[Daniel Holbert [:dholbert]]

Sure, sorry about that -- I was just focusing on the issue quoted in comment 0 and didn't notice that there were others in the log.

Comment 9

[Daniel Holbert [:dholbert]]

Attachment: Bug 1874871 part 2: Enable the css zoom about:config pref, for WPT 'getClientRects-zoom.html'. r?#layout

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc93211dbc2e
part 2: Enable the css zoom about:config pref, for WPT 'getClientRects-zoom.html'. r=TYLin

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/bc93211dbc2e

Comment 12

[Cristian Tuns]

Hello Daniel, we still have some issues here: https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&selectedTaskRun=MzkrWXfTQ5ys5twYR3nMBw.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=1f03dbc09c57c18f043a9e6e022bd36bcc094537&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cweb%2Cplatform%2Ctests%2Cwith%2Csoftware%2Cwebrender%2Cenabled%2Cwithout%2Cfission%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-web-platform-tests-swr-nofis%2Cwpt1 can you please take another look?

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1874310

Comment 14

[Daniel Holbert [:dholbert]]

(In reply to Cristian Tuns from comment #12)

Hello Daniel, we still have some issues here

sigh, sorry about that - the test names are very similar and I thought all the remaining ones were all the same test, from a quick skim of the last pass of failures.

I should probably just move this pref-toggle to be set at a directory level, so we don't have to maintain these individual .ini files (particularly if/when more tests for this feature are added).

Comment 15

[Daniel Holbert [:dholbert]]

Attachment: Bug 1874871 part 3: Enable the zoom pref at the directory level for WPTs in the cssom-view directory. r?TYLin

This patch reverts the previous two patches on this bug (which were adding
per-test pref tweaks), and instead just enables the pref at a directory level,
since there are multiple tests in this directory that exercise this feature,
and additional ones may continue to be added as css 'zoom' gets additional
spec/test/implementation work.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1930db34ed86
part 3: Enable the zoom pref at the directory level for WPTs in the cssom-view directory. r=TYLin

Comment 17

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1930db34ed86

Comment 18

[Sandor Molnar[:smolnar]]

Verified fixed in today's beta-sim