1874921 - Replace usages of SearchService.addOpenSearchEngine in test code with SearchTestUtils.promiseNewSearchEngine.

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

I want to update SearchService.addOpenSearchEngine to simplify the loading mechanism further. To make it simpler to do, I want to transition our tests to use SearchTestUtils.promiseNewSearchEngine where they are not explicitly testing the API.

This way, it will make it easier to alter the addOpenSearchEngine function signature as most of the changes for tests will be hidden in SearchTestUtils.promiseNewSearchEngine.

Note: ideally in future we'll improve the naming of the test function - I've filed bug 1874917 for that.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1874921 - Replace browser_483086.js with an xpcshell-test. r?#search-reviewers!

This test was ensuring that we correctly handle invalid searchForm urls.
We can replace that with a simple extension of our test_opensearch tests.

Depends on D198459

Depends on D198459

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1874921 - Replace usages of SearchService.addOpenSearchEngine in test code with SearchTestUtils.promiseNewSearchEngine. r?#search-reviewers!

This replaces all the test instances, apart from some of the OpenSearch tests where we need to test
the API directly.

Depends on D198722

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1aa8a11ca885
Replace browser_483086.js with an xpcshell-test. r=search-reviewers,mcheang
https://hg.mozilla.org/integration/autoland/rev/9572d20d38b7
Replace usages of SearchService.addOpenSearchEngine in test code with SearchTestUtils.promiseNewSearchEngine. r=search-reviewers,mcheang

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1aa8a11ca885
https://hg.mozilla.org/mozilla-central/rev/9572d20d38b7