1874949 - Add triggers for Review Checker setting changes

Status: RESOLVED WONTFIX

(Firefox :: Messaging System, task, P1)

Description

[Shane Hughes [:aminomancer]]

Planned feature callouts 4 and 5 will trigger when a user:

• disables "automatically open Review Checker"
• disables Review Checker

This requires 2 new FxMS triggers. There are 2 possible ways to do this:

1. Listen to the prefs controlled by these toggles and fire the trigger when the prefs changes.
2. In the forthcoming UI code, in the click listeners' callbacks, directly invoke ASRouter.sendTriggerMessage with an appropriately named trigger.

The latter depends more on the UI, which doesn't exist yet, but it's also more precisely what we want. So the ideal approach depends on when we start work on this. We can start on 1 immediately since we can decide what the names of the prefs will be, and they will be used in the UI code, or else if the UI patch uses different pref names it can also change them in the trigger listener.

Figma spec

Comment 1

[Punam Dahiya [:pdahiya]]

Potentially uplift candidate for Fx123, dependency adding review checker settings in about:preferences in progress in Fx124

Comment 2

[Shane Hughes [:aminomancer]]

preferenceObserver trigger might be good enough for this.

Comment 3

[Shane Hughes [:aminomancer]]

Not needed thanks to preferenceObserver