1876199 - Callout updates to support auto-open changes

Status: VERIFIED FIXED

(Firefox :: Shopping, enhancement, P1)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Here's the Figma link (screenshots to be added)

Bug notes:

• add new callouts 4,5 in the Figma
  • we already have the image, but only in remote settings. needs to be added in tree.
  • trigger behavior is defined in the figma.
  • anchor the callout at the shopping urlbar button
• changes to existing callouts
  • update targeting for callout 1
  • remove callout 2
• because we are past string freeze for 123, we will need to land the new strings in the preview location for shopping, then land a followup patch in a followup bug to move the strings to the permanent location in 124 nightly.

Comment 1

[kpatenio]

Attachment: Bug 1876199 - update and add new callouts for rediscoverability experiment. r=#shopping-reviewers!

Comment 2

[Shane Hughes [:aminomancer]]

Do we need to land anything? It seems like the callouts can be deployed entirely off-train. The experiment is not localized, so the callouts can be deployed just like the 1.1 callouts were deployed, with raw strings and the remote image URL.

One reason to land things would be if we're certain we want to land these callouts in tree after the experiment. Then, landing the strings early would be advantageous, since there would be more time for translation before the callouts ship.

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

yes, product wants these callouts to be on-train

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

[Tracking Requested - why for this release]: This is part of the auto-open feature would like to uplift into 123.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e361460d867
update and add new callouts for rediscoverability experiment. r=shopping-reviewers,aminomancer,fluent-reviewers,bolsson,jhirsch,niklas

Comment 6

[kpatenio]

Comment on attachment 9377266 [details]
Bug 1876199 - update and add new callouts for rediscoverability experiment. r=#shopping-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: If declined, no feature callouts will be displayed after certain user actions (ex. opting out of Review Checker for the first time, etc.) when we enable + enrol users into our rediscoverability experiment
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Details about callouts can be found in the Figma link above. Two of the callouts (for disabling auto-open and turning off Review Checker) can be tested as follows:

1. Launch a brand new profile
2. set browser.shopping.experience2023.enabled and browser.shopping.experience2023.autoOpen.enabled to true
3. open a PDP like https://www.amazon.com/dp/B07QH7ZXH3
4. Ensure Review Checker is open and opt-in to Review Checker.
5. Turn off "automatically open Review Checker" via the toggle in Review Checker settings
6. A callout should appear on the urlbar saying that Review Checker is now closed by default
7. Open Review Checker again and press the turn off Review Checker button
8. A callout should appear on the urlbar saying that Review Checker is turned off

• List of other uplifts needed: Bug 1876200
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk since the newly added callouts are gated by the prefs browser.shopping.experience2023.enabled and browser.shopping.experience2023.autoOpen.enabled (both need to be true) . The pref browser.shopping.experience2023.autoOpen.enabled is set to false by default.

Note that this patch modifies a change made in Bug 1876200. Please uplift this patch after Bug 1876200 is uplifted.

• String changes made/needed: New strings were added, but they are currently not exposed to localizers and won't be translated
• Is Android affected?: No

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6e361460d867

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9377266 [details]
Bug 1876199 - update and add new callouts for rediscoverability experiment. r=#shopping-reviewers!

Approved for 123 beta 8, thanks.

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/562b0ae0eca5

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/562b0ae0eca5

Comment 11

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly as well as our latest Beta 123.0b8.