1875465 - [Tab Strip] Add tab strip for tablets behind secret settings

Status: VERIFIED FIXED

(Fenix :: Tabs, enhancement, P2)

Description

[Rahul Sainani [:rsainani]]

The intention is to create a first working version of tab strip to improve the experience on tablets. This will also lead to information about further possible improvements that can help improve the tablet experience.

Although, not the main goal but working on this is also highlighting some of the refactoring opputunities to simplify making further iterations and as a result paving the way to support different form factors on all screens.

This includes:
– Secret Settiings - "Enable Tab Strip" that's visible only on tablets.
– Displaying open tabs in a Tab Strip above toolbar
– Display favicon for each tab
– Ability to add a new tab
– Ability to close tabs
– Private/normal browsing mode tabs are displayed when in the respective mode
– Works in tandem with tabs tray aka selecting mode/tab, adding/deletting tab in tabs tray shows the same in tabs strip and vice versa.

While these are not features of the Tab Strip UI, these are changes are in Settings when tab strip is enabled:
– toolbar customization in Settings is not shown as Toolbar defaults to Top.
– Swipe tab gesture to switch tabs in settings is not shown as it is disabled.

Note that this doesn't and shouln't affect the current mobile experience in any way, or even the current tablet experience if the secret settings is switched off.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1875465 - Add tab strip for tablets (#5218)

Comment 2

[BMO Github Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/5cbd4101e00cc6596691debed0b0153169af8539
[main] Bug 1875465 - Part 1: Set toolbar position if tablet

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/98388d8c5289baf854179caf2246740eea71885d
[main] Bug 1875465 - Part 2: Update layout and positioning logic

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/d37240f0b03f8b8f5907a400c4fea0a71fb45f00
[main] Bug 1875465 - Part 3: Add tab strip ui for tablets

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/13ad64a6c017035ed04aa5850e77b30c3a7a0e45
[main] Bug 1875465 - Part 4: Add secret setting and remove toolbar customization

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/792ca98ae461e59ef1ce9a25bd7af5c5f2829c91
[main] Bug 1875465 - Part 5: Hide tab strip when full screen

Comment 3

[Rahul Sainani [:rsainani]]

Note for QE:

The bug description includes the current feature set. If there are any issues, requesting you to please file them under the tab strip meta. There shouldn't be any changes in the usual mobile (non tablet) experience.

Comment 4

[miralobontiu]

Verified on the latest Fenix Nightly 125.0a1 from 2/29 with two tablets: Samsung Galaxy S8 Ultra (Android 12), and Lenovo tab M10 (Android 10).

Verified the following:
– in Secret Settings - "Enable Tab Strip" is visible only on tablets, and the toggle can be enabled/disabled;
– when enabled, the open tabs are displayed in a Tab Strip above TOP toolbar;
– when enabled, there is a favicon, and a "X" (close) option for each tab;
– there is the "+" icon which lets the user open a new tab;
– a new tab can be also opend by: long-tapping the tabs counter, or searching/typing in the search bar;
– the private/normal browsing mode tabs are displayed when in the respective mode;
– works in tandem with tabs tray aka selecting mode/tab, adding/deleting tab in tabs tray shows the same in tabs strip and vice versa.

The following features from Settings --> Customize are no longer available when tab strip is enabled:
– toolbar customization in Settings is not shown as Toolbar defaults to Top.
– Swipe tab gesture to switch tabs in settings is not shown as it is disabled.

@Rahul: There is one functionality that is not available when the "Enable Tabs Strip" is on: closing a tab from the Tabs Strip doesn't display the "Tab closed UNDO" snackbar.

Comment 5

[Rahul Sainani [:rsainani]]

Thank you very much [:miralobontiu] !

Regarding undo, we have this Bug 1882106 tracking that. That's not part of this bug.

Could you also please confirm that there are no changes on mobile (non tablet) devices. That would provide added assurance :)