1875517 - Suggestion: Add speed button for Youtube in picture-in-picture(PiP) modals

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, enhancement, P3)

Description

[Wellington Torrejais da Silva]

Attachment: Captura de tela de 2024-01-19 14-39-58.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:123.0) Gecko/20100101 Firefox/123.0

Steps to reproduce:

• Play youtube video: https://www.youtube.com/watch?v=Q8xawBknV4s
• Open PiP modal
• Can't change video speed from PiP Modal

Actual results:

I can't change Youtube video speed from PiP modals

Expected results:

Suggestions: Add ways to control video playing speed in PiP modals

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Picture-in-Picture' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Simon Rosen]

Attachment: Bug 1875517 - Add a playback speed control to the Picture-in-Picture player. r=#pip-reviewers

Adds a playback speed button (shown with the improved video controls) to
the Picture-in-Picture window. It opens a panel, modeled on the existing
subtitles settings panel, containing a live rate readout, a 0.25x-2x
slider, and one-tap presets for 0.5x/1x/1.5x/2x. The < and > keys step
through the standard presets.

The rate is applied to the originating video through new overridable
PictureInPictureChildVideoWrapper methods (getPlaybackRate/setPlaybackRate)
with the usual fallback implementation. A ratechange listener on the
originating video keeps the panel in sync when the rate is changed from
the page, and the originating video's rate is carried into the PiP window
when it opens (mirroring the existing volume flow).

Developed with AI assistance (Claude Code) under my direction; reviewed
and tested locally (browser_playbackRate.js) before submitting.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/593c8d056e91
https://hg.mozilla.org/integration/autoland/rev/b3575a3229cd
Add a playback speed control to the Picture-in-Picture player. r=fluent-reviewers,desktop-theme-reviewers,kpatenio,bolsson,dao

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0a2876e978f2
https://hg.mozilla.org/integration/autoland/rev/0e927194d73c
Revert "Bug 1875517 - Add a playback speed control to the Picture-in-Picture player. r=fluent-reviewers,desktop-theme-reviewers,kpatenio,bolsson,dao" for causing bc failures on browser_playbackRate.js.

Comment 5

[Iulian Moraru]

Revert for causing bc failures on browser_playbackRate.js.

• Push with failures

• Failure log

• Backout link

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/961df7232a53
https://hg.mozilla.org/integration/autoland/rev/1ee9c0836cf6
Add a playback speed control to the Picture-in-Picture player. r=fluent-reviewers,desktop-theme-reviewers,kpatenio,bolsson,dao

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1ee9c0836cf6

Comment 8

[Simon Rosen]

Re-landed as 1ee9c0836cf6 (merged to central in comment 7).

The browser_playbackRate.js failure was a test bug, not a product bug: the
playback speed button is display:none below 640x360, and the test never sized
the PiP window, so the synthesized click landed on a hidden button. The test
now resizes, waits for the button to actually be visible, and retries the
click. kpatenio's try push came back green across Linux and Windows
test-verify before re-landing.

Sorry for the delay clearing this.