1875536 - "To protect your privacy, Daily has blocked remote content in this message." was shown multiple times in the same email in Thunderbird 123.0a1

Status: VERIFIED FIXED

(Thunderbird :: Upstream Synchronization, defect)

Description

[Matt Fagnani]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:123.0) Gecko/20100101 Firefox/123.0

Steps to reproduce:

I ran Thunderbird 123.0a1 20240119105841 on Wayland in Plasma 5.92.0 in a Fedora Rawhide/40 KDE Plasma installation. I opened emails some of which contained remote content.

Actual results:

"To protect your privacy, Daily has blocked remote content in this message." was shown multiple times in the same email in Thunderbird 123.0a1. The message was shown from 2 to around 40 times depending on the email. The whole email contents were covered by the message when the 40 messages were shown.

123.0a1 2024-1-15 had the problem while 123.0a1 2024-1-9 didn't. I bisected with mozregression. The first bad revision was for Bug 1873377 - Port bug 1845150: Use moz-message-bar instead of message-bar in notificationbox.js.

4:13.73 INFO: Narrowed integration regression window from [9c9d342d, 0c94f0f2] (3 builds) to [9c9d342d, a79a1c92] (2 builds) (~1 steps left)
4:13.73 INFO: No more integration revisions, bisection finished.
4:13.73 INFO: Last good revision: 9c9d342d1e44d01fe5085482adcadbc3b7f1f1fa
4:13.73 INFO: First bad revision: a79a1c926a2af434e315670a67a137b7446674f6
4:13.73 INFO: Pushlog:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=9c9d342d1e44d01fe5085482adcadbc3b7f1f1fa&tochange=a79a1c926a2af434e315670a67a137b7446674f6

Expected results:

"To protect your privacy, Daily has blocked remote content in this message." should have been shown only once in emails with remote content.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1875536 - Avoid duplicate remote content notifications. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dadd358c0876
Avoid duplicate remote content notifications. r=mkmelin

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9375916 [details]
Bug 1875536 - Avoid duplicate remote content notifications. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Matt, thanks for the bug report

Comment 6

[Wayne Mery (:wsmwk)]

working for me on daily

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 123.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/7d4627f7d2f8