1875673 - `env()` in CSS variables incorrect

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[709922234]

Attachment: Screenshot 2024-01-21 at 20.07.27.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:123.0) Gecko/20100101 Firefox/123.0

Steps to reproduce:

https://codepen.io/mantou132/pen/poYwwBK?editors=1100

Actual results:

Gray block height is not 100%

Expected results:

Gray block height is 100%

Comment 1

[Blake]

Mozregression points to Bug 1855110 Part 3 causing this.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:dshin, since you are the author of the regressor, bug 1855110, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

[Tracking Requested - why for this release]: we shouldn't ship this regression

Comment 4

[Pascal Chevrel:pascalc]

emilio, can we get a severity set on this one? Thanks

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Severity probably depends on whether this breaks websites, but it seems somewhat likely, specially for mobile sites, so let's go with S2. I don't expect the fix here to be super-complicated.

Comment 6

[David Shin[:dshin]]

Attachment: Bug 1875673: Do not prevent early substitution of for non-registered or registered non-length variables when they reference font-relative properties. r=#style

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9365402e22a
Do not prevent early substitution of for non-registered or registered non-length variables when they reference font-relative properties. r=firefox-style-system-reviewers,emilio

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44142 for changes under testing/web-platform/tests

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d9365402e22a

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dshin, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 13

[David Shin[:dshin]]

Comment on attachment 9375804 [details]
Bug 1875673: Do not prevent early substitution of for non-registered or registered non-length variables when they reference font-relative properties. r=#style

Beta/Release Uplift Approval Request

• User impact if declined: Bug 1875673 comment 0
  In the field, Bug 1875970 comment 0 (Though on shippable builds, it'd just give a "wrong" result rather than asserting)
  Confirmed fix through mozregression --launch 2024-01-24 and navigating to codepen example in Bug 1875673 comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fix is simple (Adding one more logical check), WPT covers the usage well
• String changes made/needed:
• Is Android affected?: Yes

Comment 14

[Pascal Chevrel:pascalc]

Comment on attachment 9375804 [details]
Bug 1875673: Do not prevent early substitution of for non-registered or registered non-length variables when they reference font-relative properties. r=#style

Approved for 123 beta 3, thanks.

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/aca480ec983e

Comment 16

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/aca480ec983e