1876035 - Protocol error (session.subscribe): unknown error TypeError: can't access property "getActor", context.currentWindowGlobal is null registerNavigationListenerActor@chrome://remote/content/shared/js-window-actors/NavigationListenerActor.sys.mjs:54:9

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I got a failure report from the pdf.js folks that after upgrading Firefox to 124.0a1 some tests no longer work on some platforms.
Here a log file that shows the problem: http://54.193.163.58:8877/2a700bd7a9812d6/output.txt

Server running at http://127.0.0.1:57712/
Error while starting firefox: Protocol error (session.subscribe): unknown error TypeError: can't access property "getActor", context.currentWindowGlobal is null registerNavigationListenerActor@chrome://remote/content/shared/js-window-actors/NavigationListenerActor.sys.mjs:54:9
startMonitoring@chrome://remote/content/shared/NavigationManager.sys.mjs:115:12
startMonitoring@chrome://remote/content/shared/NavigationManager.sys.mjs:393:24
RootMessageHandler@chrome://remote/content/shared/messagehandler/RootMessageHandler.sys.mjs:70:29
_createMessageHandler@chrome://remote/content/shared/messagehandler/MessageHandlerRegistry.sys.mjs:193:28
getOrCreateMessageHandler@chrome://remote/content/shared/messagehandler/MessageHandlerRegistry.sys.mjs:147:29
get messageHandler@chrome://remote/content/shared/webdriver/Session.sys.mjs:289:41
execute@chrome://remote/content/shared/webdriver/Session.sys.mjs:270:9
onPacket@chrome://remote/content/webdriver-bidi/WebDriverBiDiConnection.sys.mjs:211:37
onMessage@chrome://remote/content/server/WebSocketTransport.sys.mjs:127:18
handleEvent@chrome://remote/content/server/WebSocketTransport.sys.mjs:109:14

I noticed that we do not run a check that the windowGlobal is actually available. We probably should add that.

Nevertheless I do not see why this has been regressed. We haven't changed that code for quite some time.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This failure has actually be seen only once so far. So it's not urgent to fix. Lets put into the backlog.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1876035 - [remote] Only register NavigationListenerActor when a window global is available.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42d77e7dae4b
[remote] Only register NavigationListenerActor when a window global is available. r=webdriver-reviewers,jdescottes

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/42d77e7dae4b