1876059 - 6.34 - 2.43% perf_reftest style-attr-1.html / sessionrestore + 2 more (OSX) regression on Tue January 16 2024

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Andrej (:aglavic)]

Perfherder has detected a talos performance regression from push 61f3fbc803a87492205485b4b8c4602add910d9e. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
6%	perf_reftest style-attr-1.html	macosx1015-64-shippable-qr	e10s fission stylo webrender	3.46 -> 3.67
4%	sessionrestore_no_auto_restore	macosx1015-64-shippable-qr	e10s fission stylo webrender	1,119.75 -> 1,159.50
3%	sessionrestore	macosx1015-64-shippable-qr	e10s fission stylo webrender	1,102.50 -> 1,136.25
2%	sessionrestore	macosx1015-64-shippable-qr	e10s fission stylo webrender	1,102.71 -> 1,129.50

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 41112

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1866098

Comment 2

[Eitan Isaacson [:eeejay]]

I am working on this.

Comment 3

[Eitan Isaacson [:eeejay]]

It looks like moving the URL collecting earlier regressed these tests a bit.

1. Current central:
   https://treeherder.mozilla.org/jobs?repo=try&revision=9073c36016722a9e47c84b40b75aceb506c6c5ee

2. Move URL collecting back to where it was:
   https://treeherder.mozilla.org/jobs?repo=try&revision=8ebf407bcf0cbaec9e05e3e1cf63adcac21acc46

I'll look into how we can preserve the functionality without regressing here. Can't promise that is possible yet.

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1876059 - Initialize mac app before migration dialog. r?spohl

In the previous patch I called InitializeMacApp earlier. This caused performance
regressions. We need to initialize it before the migration wizard in order for it
to be accessible, so I added a call just before the Migrate method.

Note: calling InitializeMacApp more than once does nothing.

Comment 5

[Bob Hood [:bhood]]

:eeejay, could you please add a Severity rating to this report?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/144947296f54
Initialize mac app before migration dialog. r=spohl

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/144947296f54

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:eeejay, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #6)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/144947296f54
Initialize mac app before migration dialog. r=spohl

== Change summary for alert #41319 (as of Mon, 05 Feb 2024 07:23:35 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
4%	sessionrestore	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	890.17 -> 851.67
4%	sessionrestore	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	887.04 -> 854.58

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=41319