1876159 - A bug has been identified in the instrumentation for 1862493

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task)

Description

[Glenda Leonard]

During testing in 123 nightly a bug was found in the instrumentation for https://bugzilla.mozilla.org/show_bug.cgi?id=1862493

The topsites.sponsored_tiles_received field in the newtab ping should never have both display_position and display_fail_reason set. The behaviour has been reproduced locally using unit tests by mimicking the system tick triggering of the tiles from the contile service.

Comment 1

[Glenda Leonard]

Attachment: Bug 1876159 Added check for display_fail_reason when setting positions.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0889e1d96f2c
Added check for display_fail_reason when setting positions. r=thecount,mconley

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0889e1d96f2c

Comment 4

[Glenda Leonard]

Attachment: Bug 1876159 Added check for display_fail_reason when setting positions.

While verifying https://bugzilla.mozilla.org/show_bug.cgi?id=1862493 in nightly, it was found that approximately 1.5.% of the the rows contained an error. This patch is to fix that issue.

3 units tests have been added, 2 explicitly around updating lists of tiles.

Original Revision: https://phabricator.services.mozilla.com/D199502

Comment 5

[Phabricator Automation]

Uplift Approval Request

• String changes made/needed: None
• Risk associated with taking this patch: Low risk
• Fix verified in Nightly: yes
• Is Android affected?: no
• Code covered by automated testing: yes
• Steps to reproduce for manual QE testing: Manual testing not required
• User impact if declined: Internal Ads dashboards will be inaccurate
• Explanation of risk level: Fixes new intrumentation added for 123.
• Needs manual QE test: no

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/814c511db3bf