1877197 - newtab telemetry bug - not setting tile position.

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task)

Description

[Glenda Leonard]

During testing in 123 nightly a bug was found in the instrumentation for https://bugzilla.mozilla.org/show_bug.cgi?id=1862493

The topsites.sponsored_tiles_received field in the newtab ping sometimes (0.18% of applicable records from nightly) does not have a tile position set when expected.

The behaviour has been reproduced locally using unit tests by mimicking the system tick triggering of the tiles from the contile service.

Comment 1

[Glenda Leonard]

Attachment: Bug 1877197 - Set display_position in error condition or set display_fail_reason = unresolved

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd2a6b0211c8
Set display_position in error condition or set display_fail_reason = unresolved r=mconley,thecount

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/dd2a6b0211c8

Comment 4

[Glenda Leonard]

Attachment: Bug 1877197 - Set display_position in error condition or set display_fail_reason = unresolved

Original Revision: https://phabricator.services.mozilla.com/D200047

Comment 5

[Phabricator Automation]

Uplift Approval Request

• User impact if declined: Internal Ads dashboards will be inaccurate
• Code covered by automated testing: yes
• Risk associated with taking this patch: Low risk
• Fix verified in Nightly: yes
• String changes made/needed: None
• Is Android affected?: no
• Steps to reproduce for manual QE testing: Manual testing not required
• Explanation of risk level: Fixes new intrumentation added for 123.
• Needs manual QE test: no

Comment 7

[Pascal Chevrel:pascalc]

This uplift request patches a file that doesn't exist on the beta branch.

Comment 8

[Glenda Leonard]

Comment on attachment 9377234 [details]
Bug 1877197 - Set display_position in error condition or set display_fail_reason = unresolved

Beta/Release Uplift Approval Request

• User impact if declined: Internal Ads dashboards will be inaccurate
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: Manual testing not required
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fixes new instrumentation added for 123.
• String changes made/needed: none
• Is Android affected?: No

Comment 9

[Glenda Leonard]

Locally git handled the file name change. I think moz-phab or mercurial does not handle file name changes in the same way?

Trying this without moz-phab to see if it will merge cleanly this way. If that doesn't work I'll need advice on next steps.

Comment 10

[Glenda Leonard]

[Tracking Requested - why for this release]: Internal Ads dashboards will be inaccurate

Comment 11

[Pascal Chevrel:pascalc]

You have documentation on how to request an uplift in phabricator/lando here:
https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift

Comment 12

[Glenda Leonard]

Attachment: Bug 1877197 - changes applied to beta

Comment 13

[Glenda Leonard]

Attachment: Bug 1877197 - changes applied to beta

Original Revision: https://phabricator.services.mozilla.com/D200940

Comment 14

[Phabricator Automation]

Uplift Approval Request

• Code covered by automated testing: yes
• String changes made/needed: None
• Fix verified in Nightly: yes
• User impact if declined: Internal Ads dashboards will be inaccurate
• Is Android affected?: no
• Steps to reproduce for manual QE testing: Manual testing not required
• Risk associated with taking this patch: Low risk
• Needs manual QE test: no
• Explanation of risk level: Fixes new intrumentation added for 123.

Comment 15

[Glenda Leonard]

Attachment: Bug 1877197 - Set display_position in error condition or set display_fail_reason = unresolved

Comment 16

[Glenda Leonard]

Attachment: Bug 1877197 - Set display_position in error condition or set display_fail_reason = unresolved

Original Revision: https://phabricator.services.mozilla.com/D200949

Comment 17

[Phabricator Automation]

Uplift Approval Request

• Explanation of risk level: Fixes new intrumentation added for 123.
• Risk associated with taking this patch: Low risk
• Needs manual QE test: no
• User impact if declined: Internal Ads dashboards will be inaccurate
• Is Android affected?: no
• Steps to reproduce for manual QE testing: Manual testing not required
• String changes made/needed: None
• Code covered by automated testing: yes
• Fix verified in Nightly: yes

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/1b91d8eb60be