1876197 - Implement auto-open shopping sidebar behavior

Status: VERIFIED FIXED

(Firefox :: Shopping, enhancement, P1)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Here's the Figma link (screenshots to be added)

Roughly: when an opted-in user closes the sidebar, flipping the active pref to false, if the browser.shopping.experience2023.autoOpen pref is true, start counting page views or minutes (TBD which we'll track), then when the count/timer runs out, if there's no callout displayed, flip the active pref back to true.

Note that we can check if a callout is displayed by importing FeatureCalloutBroker and checking isCalloutShowing.

Since this change is adding an app-global counter, ShoppingUtils is probably a natural spot for it.

We've now heard that the frequency is supposed to mimic auto-open behavior. So, you close the sidebar, navigate to another product page, and the sidebar comes back. There is no delay except waiting for the user to navigate to a new product page.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1876197 - Implement auto-open shopping sidebar behavior r?#shopping-reviewers

If auto open is enabled, whenever the user closes the sidebar, set it to
reopen automatically, flipping the 'active' pref back to true, either
the next time they visit a supported product page in the same session,
or at startup time of the next session.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c80d4502302c
Implement auto-open shopping sidebar behavior r=shopping-reviewers,niklas

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures at browser/components/shopping/tests/browser/browser_shopping_message_triggers.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/5cb137f1e274341a1fb458ecb24f0c7dddb10523

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_shopping_message_triggers.js | Test timed out

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65888f9bd2aa
Implement auto-open shopping sidebar behavior r=shopping-reviewers,niklas

Comment 5

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Think I've got the test fixed, thanks!

Comment 6

[Noemi Erli[:noemi_erli]]

Backed out changeset 65888f9bd2aa (Bug 1876197) for causing failures in browser_recommended_ad_test.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=AlwSYspTSPKDXtiOuRPiSg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=65888f9bd2aaeb1123d05ea576c2db011acf4655

Log: https://treeherder.mozilla.org/logviewer?job_id=444813300&repo=autoland&lineNumber=4180

Backout: https://hg.mozilla.org/integration/autoland/rev/fff64ab8066f316e6486d272d9e2ee1b671fb0ac

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Sorry about that! Trying this one more time...

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1d532998276
Implement auto-open shopping sidebar behavior r=shopping-reviewers,niklas

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e1d532998276

Comment 10

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 9376534 [details]
Bug 1876197 - Implement auto-open shopping sidebar behavior r?#shopping-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Product would like to experiment with a variation on the shopping behavior in 123, in which auto-open behavior makes the shopping sidebar more rediscoverable.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: Verify the new auto-open experience with browser.shopping.experience2023.autoOpen.enabled toggled to true, and verify the old behavior with the pref left as false. See the bug description and linked Figma for details.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change only touches code that is preffed off by default, and will only be enabled experimentally for a small percentage of en-US users. If anything goes wrong with the experiment, it can be ended early.
• String changes made/needed: NA
• Is Android affected?: No

Comment 11

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

[Tracking Requested - why for this release]: This is part of the overall project we're aiming to uplift into 123 (all grouped under metabug 1875324)

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9376534 [details]
Bug 1876197 - Implement auto-open shopping sidebar behavior r?#shopping-reviewers

Approved for 123 beta 8, thanks.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/8aef1335f194

Comment 14

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/8aef1335f194

Comment 15

[Rares Doghi, Desktop QA]

Marking this issue Verified as fixed, and we logged Bug 1878908 for the remaining Walmart issue.