1878908 - Review Checker v.1.1 will not Auto open for Walmart Product Details pages

Status: VERIFIED FIXED

(Firefox :: Shopping, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: WalmartsWont.mp4

Found in

• Nightly 124.0a1 (2024-02-06)

Affected versions

• Nightly 124.0a1 (2024-02-06)
• Beta 123.0b8

Affected platforms

• All

Preconditions:
Reach about:config and set the following prefs:
browser.shopping.experience2023.enabled, set to true (doubleclick)
browser.shopping.experience2023.optedIn, set to 1 (doubleclick, input ‘0’, hit enter)
browser.shopping.experience2023.autoOpen.enabled - true
browser.shopping.experience2023.autoOpen.userEnabled - true

Steps to reproduce

1. Reach : https://www.amazon.com/XUEGW-Computer-Assembly-Required-Foldable/dp/B0CDS1238W/ref=sr_1_2_sspa?keywords=desk&qid=1706529514&sr=8-2-spons&sp_csd=d2lkZ2V0TmFtZT1zcF9hdGY&th=1
2. Close the Review Checker from the X Close button.
3. Reach walmart.com in a new tab or in the same tab.
4. Select and reach any product details page.

Expected result

• Review Checker v1.1 should open Automatically when reaching a supported Product Details page.

Actual result

• The Review Checker will not open automatically for Products from Walmart.
  The Review Checker will only open automatically for products from amazon.com or bestbuy.com

Regression range
Not a Regression

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1878908 - Fix auto open shopping sidebar on Walmart PDP. r=#shopping-reviewers

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

(In reply to Rares Doghi, Desktop QA from comment #0)

Created attachment 9378562 [details]
WalmartsWont.mp4

Found in

• Nightly 124.0a1 (2024-02-06)

Affected versions

• Nightly 124.0a1 (2024-02-06)
• Beta 123.0b8

Affected platforms

• All

Preconditions:
Reach about:config and set the following prefs:
browser.shopping.experience2023.enabled, set to true (doubleclick)
browser.shopping.experience2023.optedIn, set to 1 (doubleclick, input ‘0’, hit enter)
browser.shopping.experience2023.autoOpen.enabled - true
browser.shopping.experience2023.autoOpen.userEnabled - true

Steps to reproduce

1. Reach : https://www.amazon.com/XUEGW-Computer-Assembly-Required-Foldable/dp/B0CDS1238W/ref=sr_1_2_sspa?keywords=desk&qid=1706529514&sr=8-2-spons&sp_csd=d2lkZ2V0TmFtZT1zcF9hdGY&th=1
2. Close the Review Checker from the X Close button.
3. Reach walmart.com in a new tab or in the same tab.
4. Select and reach any product details page.

Expected result

• Review Checker v1.1 should open Automatically when reaching a supported Product Details page.

Actual result

• The Review Checker will not open automatically for Products from Walmart.
  The Review Checker will only open automatically for products from amazon.com or bestbuy.com

Regression range
Not a Regression

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

This is a major bug that breaks the auto-open feature on walmart; setting the severity to S2.

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

[Tracking Requested - why for this release]: QA just found this major bug in the shopping changes we're targeting into 123. The fix is small and already R+.

Comment 5

[Pascal Chevrel:pascalc]

Can you land this like now + request uplift to have it in the last nightly before building beta 8? Thanks

Comment 6

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

:niklas has already queued it for landing, but it looks like autoland is unfortunately closed at the moment

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d87eb92ed10
Fix auto open shopping sidebar on Walmart PDP. r=shopping-reviewers,jhirsch

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1d87eb92ed10

Comment 9

[Pascal Chevrel:pascalc]

Please request uplift to beta, thanks!

Comment 10

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build. Walmart will auto-Open when we reach the PDP.

Comment 11

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 9378595 [details]
Bug 1878908 - Fix auto open shopping sidebar on Walmart PDP. r=#shopping-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: We need to pick up this bug fix to get the shopping experiment working correctly in 123
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very small bug fix for an experimental feature that is preffed off by default and will only be seen by a very small percentage of en-US users in 123
• String changes made/needed: None
• Is Android affected?: No

Comment 12

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Uplift requested, thanks! will this make today's build?

Comment 13

[Pascal Chevrel:pascalc]

(In reply to Jared Hirsch [:jhirsch] (he/him) (Needinfo please) from comment #12)

Uplift requested, thanks! will this make today's build?

Thanks, no we already built it.

Comment 14

[Pascal Chevrel:pascalc]

Comment on attachment 9378595 [details]
Bug 1878908 - Fix auto open shopping sidebar on Walmart PDP. r=#shopping-reviewers

Approved for 123 beta 9, thanks.

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ac06adb6416f

Comment 16

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 123.0b9.