1876198 - Add new auto-open toggle to settings card

Status: VERIFIED FIXED

(Firefox :: Shopping, enhancement, P1)

Description

[Jared Hirsch [:jhirsch] (PTO, back 5/28) (he/him) (Needinfo please)]

Here's the Figma link (screenshots to be added)

Notes:

• The auto-open toggle should go below the ads toggle
• also need to default the settings card to be open, not closed, by default
• if the auto-open toggle is flipped from true to false, we should flip the browser.shopping.experience2023.autoOpen pref and also flip the 'active' pref to false
• because we are past string freeze for 123, we will need to land the new strings in the preview location for shopping, then land a followup patch in a followup bug to move the strings to the permanent location in 124 nightly.

Comment 1

[kpatenio]

Attachment: Bug 1876198 - update settings card and add auto-open toggle r=#shopping-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b760ba36570e
update settings card and add auto-open toggle r=shopping-reviewers,fluent-reviewers,jhirsch,flod

Comment 3

[kpatenio]

Comment on attachment 9376366 [details]
Bug 1876198 - update settings card and add auto-open toggle r=#shopping-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: If declined, there will be no way for users enrolled into our rediscoverability experiment to modify auto-open behaviour toggled by the pref browser.shopping.experience2023.autoOpen.userEnabled.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1876608
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): UI changes from this patch are only visible to users if the pref browser.shopping.experience2023.autoOpen.enabled is true. Please note that Bug 1876608 should be uplifted first to ensure that browser.shopping.experience2023.autoOpen.enabled is false by default and won't affect all beta users.
• String changes made/needed:
• Is Android affected?: No

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b760ba36570e

Comment 5

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/7fc01c44920e

Comment 6

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/7fc01c44920e

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9376366 [details]
Bug 1876198 - update settings card and add auto-open toggle r=#shopping-reviewers!

Approved for 123 beta 6, thanks.

Comment 8

[Pascal Chevrel:pascalc]

Bustage on beta
https://hg.mozilla.org/releases/mozilla-beta/rev/9fde9b753918

Comment 9

[Pascal Chevrel:pascalc]

Bug 1876608 probably needs to be rebased before uplifting, thanks.

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/a8f990a1461e

Comment 11

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/a8f990a1461e

Comment 12

[Rares Doghi, Desktop QA]

This is Verified as fixed in Beta 123.0b8 as well as our latest Nightly build but the Main status flag here is marked as Reopened. @Jared is there something else that needs to be implemented here ?

Comment 13

[Jared Hirsch [:jhirsch] (PTO, back 5/28) (he/him) (Needinfo please)]

The bug got reopened when it was backed out of beta. Feel free to close, thanks!

Comment 14

[Rares Doghi, Desktop QA]

Updating the main status flag, Thank you @Jared