1876608 - Register autoOpen.enabled as a setPref in Nimbus FeatureManifest.yaml

Status: VERIFIED FIXED

(Firefox Graveyard :: Shopping, enhancement, P1)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Following the approach we took for the ads.enabled pref, see [1], we similarly want to register the autoOpen.enabled pref with Nimbus, so that we can remotely set that pref.

[1] https://searchfox.org/mozilla-central/source/toolkit/components/nimbus/FeatureManifest.yaml#1960-1965

Comment 1

[kpatenio]

While we're at it, let's also change the default boolean of autoOpen.enabled to false for the sake of the experiment.
Once done, I think we'll need to uplift this patch after the uplift request for Bug 1876568 has been approved and processed.

Comment 2

[kpatenio]

Attachment: Bug 1876608 - register autoOpen feature flag in Nimbus and set pref to false by default. r=#shopping-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e847b3df960
register autoOpen feature flag in Nimbus and set pref to false by default. r=shopping-reviewers,jhirsch

Comment 4

[kpatenio]

Comment on attachment 9377223 [details]
Bug 1876608 - register autoOpen feature flag in Nimbus and set pref to false by default. r=#shopping-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: If declined, any implemented behaviour uplifted to beta behind the pref browser.shopping.experience2023.autoOpen.enabled will be visible to beta users by default (ex. Bug 1876198). The pref should be set to false to hide this behaviour and should only be flipped via Nimbus.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Does not change an existing behaviour. Only prefs and Nimbus variables are affected by this patch.
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3e847b3df960

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/09eeddedacd1

Comment 7

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/09eeddedacd1

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9377223 [details]
Bug 1876608 - register autoOpen feature flag in Nimbus and set pref to false by default. r=#shopping-reviewers!

Approved for 123 beta 6, thanks.

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/f84fdc01b643

Comment 10

[Pascal Chevrel:pascalc]

This was backed out of beta for build bustage, looks like the patch needs rebasing. Katherine could you provide a rebased patch? Thanks

Comment 11

[kpatenio]

Hi Pascal,

Thanks. I updated the original patch and rebased it with beta. I'm not familiar with dealing with back outs from beta, so please let me know if I'm missing a step to resolve the issue.

Comment 12

[kpatenio]

Attachment: Bug 1876608 - register autoOpen feature flag in Nimbus and set pref to false by default.

Comment 13

[kpatenio]

I was advised to make a new beta-specific patch. The new patch also has the proper fix, so please disregard the change I made for the initial one. Apologies for any confusion!

Removing NI since the approval-mozilla-beta was already flagged.

Comment 14

[kpatenio]

Comment on attachment 9377766 [details]
Bug 1876608 - register autoOpen feature flag in Nimbus and set pref to false by default.

Beta/Release Uplift Approval Request

• User impact if declined: If declined, any implemented behaviour uplifted to beta behind the pref browser.shopping.experience2023.autoOpen.enabled will be visible to beta users by default (ex. Bug 1876198). The pref should be set to false to hide this behaviour and should only be flipped via Nimbus.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: This patch needs to be uplifted before we can uplift Bug 1876198
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Does not change any existing behaviour. Only prefs and Nimbus variables are affected by this patch.
• String changes made/needed:
• Is Android affected?: No

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/43dd08e63174

Comment 16

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/43dd08e63174

Comment 17

[Rares Doghi, Desktop QA]

I was able to verify this issue by checking this file : https://searchfox.org/mozilla-central/source/toolkit/components/nimbus/FeatureManifest.yaml
Can we mark this Verified as fixed ? @Jared

Comment 18

[Rares Doghi, Desktop QA]

Its here as well: https://searchfox.org/mozilla-beta/source/toolkit/components/nimbus/FeatureManifest.yaml

Comment 19

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Yes, this got reopened when it was backed out of beta. Feel free to close

Comment 20

[Rares Doghi, Desktop QA]

Updating the Flags. Thanks @Jared