Closed Bug 1876608 Opened 4 months ago Closed 3 months ago

Register autoOpen.enabled as a setPref in Nimbus FeatureManifest.yaml

Categories

(Firefox :: Shopping, enhancement, P1)

Product:
Firefox
Component:
Shopping
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
124 Branch
Tracking Flags:
Tracking Status
firefox123 --- verified
firefox124 --- verified

People

(Reporter: jhirsch, Assigned: kpatenio)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-shopping])

Attachments

(1 file, 1 obsolete file)

Bug 1876608 - register autoOpen feature flag in Nimbus and set pref to false by default.
48 bytes, text/x-phabricator-request
Details | Review

Following the approach we took for the ads.enabled pref, see [1], we similarly want to register the autoOpen.enabled pref with Nimbus, so that we can remotely set that pref.

[1] https://searchfox.org/mozilla-central/source/toolkit/components/nimbus/FeatureManifest.yaml#1960-1965

While we're at it, let's also change the default boolean of autoOpen.enabled to false for the sake of the experiment.
Once done, I think we'll need to uplift this patch after the uplift request for Bug 1876568 has been approved and processed.

Assignee: nobody → kpatenio
Status: NEW → ASSIGNED
Pushed by kpatenio@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e847b3df960
register autoOpen feature flag in Nimbus and set pref to false by default. r=shopping-reviewers,jhirsch

Comment on attachment 9377223 [details]
Bug 1876608 - register autoOpen feature flag in Nimbus and set pref to false by default. r=#shopping-reviewers!

Beta/Release Uplift Approval Request

  • User impact if declined: If declined, any implemented behaviour uplifted to beta behind the pref browser.shopping.experience2023.autoOpen.enabled will be visible to beta users by default (ex. Bug 1876198). The pref should be set to false to hide this behaviour and should only be flipped via Nimbus.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Does not change an existing behaviour. Only prefs and Nimbus variables are affected by this patch.
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9377223 - Flags: approval-mozilla-beta?

https://hg.mozilla.org/mozilla-central/rev/3e847b3df960

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox124: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch

Comment on attachment 9377223 [details]
Bug 1876608 - register autoOpen feature flag in Nimbus and set pref to false by default. r=#shopping-reviewers!

Approved for 123 beta 6, thanks.

Attachment #9377223 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

https://hg.mozilla.org/releases/mozilla-beta/rev/f84fdc01b643

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

This was backed out of beta for build bustage, looks like the patch needs rebasing. Katherine could you provide a rebased patch? Thanks

status-firefox123: fixed → affected
Flags: needinfo?(kpatenio)

Hi Pascal,

Thanks. I updated the original patch and rebased it with beta. I'm not familiar with dealing with back outs from beta, so please let me know if I'm missing a step to resolve the issue.

Flags: needinfo?(kpatenio) → needinfo?(pascalc)
Attachment #9377766 - Flags: approval-mozilla-beta?

I was advised to make a new beta-specific patch. The new patch also has the proper fix, so please disregard the change I made for the initial one. Apologies for any confusion!

Removing NI since the approval-mozilla-beta was already flagged.

Flags: needinfo?(pascalc)

Comment on attachment 9377766 [details]
Bug 1876608 - register autoOpen feature flag in Nimbus and set pref to false by default.

Beta/Release Uplift Approval Request

  • User impact if declined: If declined, any implemented behaviour uplifted to beta behind the pref browser.shopping.experience2023.autoOpen.enabled will be visible to beta users by default (ex. Bug 1876198). The pref should be set to false to hide this behaviour and should only be flipped via Nimbus.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: This patch needs to be uplifted before we can uplift Bug 1876198
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Does not change any existing behaviour. Only prefs and Nimbus variables are affected by this patch.
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9377766 - Flags: approval-mozilla-beta?

I was able to verify this issue by checking this file : https://searchfox.org/mozilla-central/source/toolkit/components/nimbus/FeatureManifest.yaml
Can we mark this Verified as fixed ? @Jared

Flags: needinfo?(jhirsch)

Yes, this got reopened when it was backed out of beta. Feel free to close

Flags: needinfo?(jhirsch)
Status: REOPENED → RESOLVED
Closed: 3 months ago → 3 months ago
Resolution: --- → FIXED

Updating the Flags. Thanks @Jared

Status: RESOLVED → VERIFIED
status-firefox123: fixed → verified
status-firefox124: fixed → verified
Attachment #9377223 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: