1876209 - Add autoOpen pref

Status: VERIFIED FIXED

(Firefox Graveyard :: Shopping, enhancement, P1)

Description

[❌ PTO, back 8/18 ❌ Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Mentioned in several bugs, but there's no clear bug that needs to own this task, so giving it a separate micro bug:

add a boolean browser.shopping.experience2023.autoOpen pref, defaulted to true.

Comment 1

[kpatenio]

Attachment: Bug 1876209 - add autoOpen pref for shopping sidebar. r=#shopping-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c9101ed480d
add autoOpen pref for shopping sidebar. r=shopping-reviewers,jhirsch

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2c9101ed480d

Comment 4

[kpatenio]

Comment on attachment 9376298 [details]
Bug 1876209 - add autoOpen pref for shopping sidebar. r=#shopping-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: We want to run an experiment that's ready by release 123 to test rediscoverability for Review Checker. In this patch, we merely add a pref browser.shopping.experience2023.autoOpen that will be used to enable/disable the feature. If declined, there will be no way for users to enrol into this experience once it's implemented.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Patch adds a pref that can only be edited in about:config. It currently does nothing since no behaviour has been implemented yet.
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Comment on attachment 9376298 [details]
Bug 1876209 - add autoOpen pref for shopping sidebar. r=#shopping-reviewers!

Approved for 123 beta 3, thanks.

Comment 6

[Pascal Chevrel:pascalc (PTO until Sept 2)]

https://hg.mozilla.org/releases/mozilla-beta/rev/bddfd42b622a

Comment 7

[Rares Doghi, Desktop QA]

This is verified as fixed, the pref is there but its False by default, in the description of this issue is mentioned that it should be defaulted True ? @Jared

Comment 8

[❌ PTO, back 8/18 ❌ Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Sorry for the confusion--after I filed this bug, :kpatenio pointed out that we needed two separate prefs, one reflecting user toggle of the feature, and one that could be remotely controlled via nimbus to enroll users in the feature experiment. This error was corrected by bug 1876568, which has also been uplifted.