1876568 - Add a new pref for auto-open toggle

Status: VERIFIED FIXED

(Firefox Graveyard :: Shopping, task)

Description

[kpatenio]

The pref landed in Bug 876209 is for enabling/disabling the new WIP auto-open feature as a whole including new callouts and settings UI changes. This other pref however is for the toggle itself (enable or disable auto-open behaviour only) and will be set by the user via the settings card.

Comment 1

[kpatenio]

Attachment: Bug 1876568 - add new pref for auto-open toggle and distinguish from feature flag. r=#shopping-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b17cf96fb6db
add new pref for auto-open toggle and distinguish from feature flag. r=shopping-reviewers,jhirsch

Comment 3

[kpatenio]

Comment on attachment 9376481 [details]
Bug 1876568 - add new pref for auto-open toggle and distinguish from feature flag. r=#shopping-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: Similar to Bug 1876209, we will use this pref in an experiment for Review Checker rediscoverability. This patch is a follow-up to that one, this time adding another pref browser.shopping.autoOpen.userEnabled that's meant to be set from UI. If declined, users won't have a way to enable/disable behaviour toggled by the experiment once it's implemented.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The added pref doesn't do anything yet. Behaviour will be implemented in a separate patch.
• String changes made/needed:
• Is Android affected?: No

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b17cf96fb6db

Comment 5

[Pascal Chevrel:pascalc]

Comment on attachment 9376481 [details]
Bug 1876568 - add new pref for auto-open toggle and distinguish from feature flag. r=#shopping-reviewers!

Approved for 123 beta 3, thanks.

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/c05637a5653c

Comment 7

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/c05637a5653c

Comment 8

[Rares Doghi, Desktop QA]

Verified as fixed, turning off this pref will no longer show the Automatically open Review Checker on the Settings card.