1876220 - Copy/paste from inspector has extra line

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[tbob13]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:122.0) Gecko/20100101 Firefox/122.0

Steps to reproduce:

Copy/paste from inspector to text editor. Extra line before { that should not be there.

Actual results:

#header a, #header button, #header input
{
outline: 0;
}

Expected results:

#header a, #header button, #header input {
outline: 0;
}

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Inspector' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Julian Descottes [:jdescottes]]

Thanks for filing, this was probably introduced when we switched the "highlighter" button between the selector and the opening bracket to a button. Will likely need to switch to a div with role=button.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1876220 - [devtools] Prevent selector highlighter to add new line to clipboard when copy/pasting. r=#devtools-reviewers.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3629891cc2d7
[devtools] Prevent selector highlighter to add new line to clipboard when copy/pasting. r=devtools-reviewers,jdescottes.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1844053

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3629891cc2d7

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nchevobbe, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1876220 - [devtools] Prevent selector highlighter to add new line to clipboard when copy/pasting. r=#devtools-reviewers.

Original Revision: https://phabricator.services.mozilla.com/D199707

Comment 9

[Phabricator Automation]

Uplift Approval Request

• String changes made/needed: -
• Is Android affected?: no
• Explanation of risk level: one-line CSS only change
• Fix verified in Nightly: no
• User impact if declined: copying a rule in the inspector and pasting it will produce an annoying extra new line
• Code covered by automated testing: no
• Needs manual QE test: no
• Risk associated with taking this patch: low
• Steps to reproduce for manual QE testing: -

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1876220 - [devtools] Prevent selector highlighter to add new line to clipboard when copy/pasting. r=#devtools-reviewers.

Original Revision: https://phabricator.services.mozilla.com/D199707

Comment 11

[Phabricator Automation]

Uplift Approval Request

• String changes made/needed: -
• Is Android affected?: no
• Explanation of risk level: one-line devtools, CSS only change
• Code covered by automated testing: no
• User impact if declined: copying a rule in the inspector and pasting it will produce an annoying extra new line
• Fix verified in Nightly: no
• Needs manual QE test: no
• Risk associated with taking this patch: low
• Steps to reproduce for manual QE testing: -

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/7fdcb4812fde

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/013cef2aab19