1876257 - AttributeError: 'Config' object has no attribute 'name' when auto-submitting after updating moz-phab to 1.5.0

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

I had to remove the auto-submit from the configuration to proceed:

ERROR    2024-01-24 11:15:43,127 Traceback (most recent call last):
  File "/home/emilio/.local/lib/python3.11/site-packages/mozphab/mozphab.py", line 126, in main
    args.func(repo, args)
  File "/home/emilio/.local/lib/python3.11/site-packages/mozphab/commands/submit.py", line 709, in submit
    raise e
  File "/home/emilio/.local/lib/python3.11/site-packages/mozphab/commands/submit.py", line 700, in submit
    _submit(repo, args)
  File "/home/emilio/.local/lib/python3.11/site-packages/mozphab/commands/submit.py", line 554, in _submit
    "Automatically submitting (as per submit.auto_submit in %s)", config.name
                                                                  ^^^^^^^^^^^
AttributeError: 'Config' object has no attribute 'name'

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Regressed by https://github.com/mozilla-conduit/review/commit/72b2637e8a198e3b083514e8e0ff3565d73c6ef8

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1876257 - config: add a missing rename from name to filename. r=sheehan,zeid

Comment 3

[Zeid [:zeid]]

Regressed by https://phabricator.services.mozilla.com/D197187 (no bug).

Comment 5

[Connor Sheehan [:sheehan]]

I'm going to publish a 1.5.1 release to get this fix out.

We should add an integration test for the auto-submit functionality while we're at it.

Comment 7

[Connor Sheehan [:sheehan]]

Resolved in moz-phab 1.5.1.