Open Bug 1876359 Opened 2 years ago Updated 6 months ago

Intermittent browser/components/extensions/test/browser/browser_unified_extensions.js | single tracking bug

Categories

(WebExtensions :: Untriaged, defect, P5)

defect

Tracking

(Not tracked)

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, test-verify-fail)

Attachments

(1 obsolete file)

Filed by: sstanca [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=444484592&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/WxW2bJafTy2eSTh_JoNHGw/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/WxW2bJafTy2eSTh_JoNHGw/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1


[task 2024-01-24T18:09:13.850Z] 18:09:13     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_unified_extensions.js | expected panel to be hidden - 
[task 2024-01-24T18:09:13.851Z] 18:09:13     INFO - Leaving test bound test_clicks_on_unified_extension_button
[task 2024-01-24T18:09:13.851Z] 18:09:13     INFO - Entering test bound test_item_shows_the_best_addon_icon
[task 2024-01-24T18:09:13.852Z] 18:09:13     INFO - Extension loaded
[task 2024-01-24T18:09:13.852Z] 18:09:13     INFO - Buffered messages finished
[task 2024-01-24T18:09:13.855Z] 18:09:13     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_unified_extensions.js | uncaught exception - TypeError: can't access property "getWrapper", policy.extension.tabManager is undefined at getState@resource://gre/modules/ExtensionPermissions.sys.mjs:510:15
[task 2024-01-24T18:09:13.855Z] 18:09:13     INFO - getAttentionState@resource://gre/modules/ExtensionPermissions.sys.mjs:597:24
[task 2024-01-24T18:09:13.855Z] 18:09:13     INFO - updateAttention@chrome://browser/content/browser-addons.js:1223:33
[task 2024-01-24T18:09:13.855Z] 18:09:13     INFO - onPanelViewHiding/<@chrome://browser/content/browser-addons.js:1393:38
[task 2024-01-24T18:09:13.855Z] 18:09:13     INFO - FrameRequestCallback*onPanelViewHiding@chrome://browser/content/browser-addons.js:1393:26
[task 2024-01-24T18:09:13.855Z] 18:09:13     INFO - handleEvent@chrome://browser/content/browser-addons.js:1329:14
[task 2024-01-24T18:09:13.855Z] 18:09:13     INFO - dispatchCustomEvent@resource:///modules/PanelMultiView.sys.mjs:187:15
[task 2024-01-24T18:09:13.855Z] 18:09:13     INFO - dispatchCustomEvent@resource:///modules/PanelMultiView.sys.mjs:1501:18
[task 2024-01-24T18:09:13.855Z] 18:09:13     INFO - _closeLatestView@resource:///modules/PanelMultiView.sys.mjs:917:15
[task 2024-01-24T18:09:13.855Z] 18:09:13     INFO - closeAllViews@resource:///modules/PanelMultiView.sys.mjs:931:12
[task 2024-01-24T18:09:13.855Z] 18:09:13     INFO - handleEvent@resource:///modules/PanelMultiView.sys.mjs:1294:14
[task 2024-01-24T18:09:13.856Z] 18:09:13     INFO - hidePopup@resource:///modules/PanelMultiView.sys.mjs:628:19
[task 2024-01-24T18:09:13.856Z] 18:09:13     INFO - hidePopup@resource:///modules/PanelMultiView.sys.mjs:294:40
[task 2024-01-24T18:09:13.856Z] 18:09:13     INFO - togglePanel@chrome://browser/content/browser-addons.js:1576:24
[task 2024-01-24T18:09:13.856Z] 18:09:13     INFO - onmousedown@chrome://browser/content/browser.xhtml:1:20
[task 2024-01-24T18:09:13.856Z] 18:09:13     INFO - closeExtensionsPanel@chrome://mochitests/content/browser/browser/components/extensions/test/browser/head_unified_extensions.js:44:10
[task 2024-01-24T18:09:13.856Z] 18:09:13     INFO - test_clicks_on_unified_extension_button@chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_unified_extensions.js:196:11
[task 2024-01-24T18:09:13.856Z] 18:09:13     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1138:26
[task 2024-01-24T18:09:13.856Z] 18:09:13     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1210:18
[task 2024-01-24T18:09:13.856Z] 18:09:13     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1352:14
[task 2024-01-24T18:09:13.856Z] 18:09:13     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1121:14
[task 2024-01-24T18:09:13.856Z] 18:09:13     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2024-01-24T18:09:13.856Z] 18:09:13     INFO - 
[task 2024-01-24T18:09:13.856Z] 18:09:13     INFO - Stack trace:
[task 2024-01-24T18:09:13.856Z] 18:09:13     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:2044
[task 2024-01-24T18:09:13.856Z] 18:09:13     INFO - OnErrorEventHandlerNonNull*chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:null:2019
[task 2024-01-24T18:09:13.856Z] 18:09:13     INFO - chrome://mochikit/content/browser-test.js:Tester:177
[task 2024-01-24T18:09:13.856Z] 18:09:13     INFO - chrome://mochikit/content/browser-harness.xhtml:createTester/</<:261
[task 2024-01-24T18:09:13.857Z] 18:09:13     INFO - GECKO(7020) | JavaScript error: resource://gre/modules/ExtensionPermissions.sys.mjs, line 510: TypeError: can't access property "getWrapper", policy.extension.tabManager is undefined
[task 2024-01-24T18:09:13.859Z] 18:09:13     INFO - Console message: [JavaScript Error: "TypeError: can't access property "getWrapper", policy.extension.tabManager is undefined" {file: "resource://gre/modules/ExtensionPermissions.sys.mjs" line: 510}]
[task 2024-01-24T18:09:13.860Z] 18:09:13     INFO - getState@resource://gre/modules/ExtensionPermissions.sys.mjs:510:15
[task 2024-01-24T18:09:13.860Z] 18:09:13     INFO - getAttentionState@resource://gre/modules/ExtensionPermissions.sys.mjs:597:24
[task 2024-01-24T18:09:13.860Z] 18:09:13     INFO - updateAttention@chrome://browser/content/browser-addons.js:1223:33
[task 2024-01-24T18:09:13.860Z] 18:09:13     INFO - onPanelViewHiding/<@chrome://browser/content/browser-addons.js:1393:38
[task 2024-01-24T18:09:13.860Z] 18:09:13     INFO - FrameRequestCallback*onPanelViewHiding@chrome://browser/content/browser-addons.js:1393:26
[task 2024-01-24T18:09:13.860Z] 18:09:13     INFO - handleEvent@chrome://browser/content/browser-addons.js:1329:14
[task 2024-01-24T18:09:13.860Z] 18:09:13     INFO - dispatchCustomEvent@resource:///modules/PanelMultiView.sys.mjs:187:15
[task 2024-01-24T18:09:13.860Z] 18:09:13     INFO - dispatchCustomEvent@resource:///modules/PanelMultiView.sys.mjs:1501:18
[task 2024-01-24T18:09:13.860Z] 18:09:13     INFO - _closeLatestView@resource:///modules/PanelMultiView.sys.mjs:917:15
[task 2024-01-24T18:09:13.860Z] 18:09:13     INFO - closeAllViews@resource:///modules/PanelMultiView.sys.mjs:931:12
[task 2024-01-24T18:09:13.861Z] 18:09:13     INFO - handleEvent@resource:///modules/PanelMultiView.sys.mjs:1294:14
[task 2024-01-24T18:09:13.861Z] 18:09:13     INFO - hidePopup@resource:///modules/PanelMultiView.sys.mjs:628:19
[task 2024-01-24T18:09:13.861Z] 18:09:13     INFO - hidePopup@resource:///modules/PanelMultiView.sys.mjs:294:40
[task 2024-01-24T18:09:13.861Z] 18:09:13     INFO - togglePanel@chrome://browser/content/browser-addons.js:1576:24
[task 2024-01-24T18:09:13.861Z] 18:09:13     INFO - onmousedown@chrome://browser/content/browser.xhtml:1:20
[task 2024-01-24T18:09:13.861Z] 18:09:13     INFO - closeExtensionsPanel@chrome://mochitests/content/browser/browser/components/extensions/test/browser/head_unified_extensions.js:44:10
[task 2024-01-24T18:09:13.861Z] 18:09:13     INFO - test_clicks_on_unified_extension_button@chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_unified_extensions.js:196:11
[task 2024-01-24T18:09:13.861Z] 18:09:13     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1138:26
[task 2024-01-24T18:09:13.861Z] 18:09:13     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1210:18
[task 2024-01-24T18:09:13.861Z] 18:09:13     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1352:14
[task 2024-01-24T18:09:13.861Z] 18:09:13     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1121:14
[task 2024-01-24T18:09:13.861Z] 18:09:13     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2024-01-24T18:09:13.861Z] 18:09:13     INFO - 
[task 2024-01-24T18:09:13.862Z] 18:09:13     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_unified_extensions.js | window has the required resolution - 

:Gijs, since you are the author of the regressor, bug 1780071, could you take a look?

For more information, please visit BugBot documentation.

Flags: needinfo?(gijskruitbosch+bugs)

Given this is a TV fail I expect I am not really the "author of the regression", we've just not touched this test for a long time. And indeed, the hg log says it's not been touched for about 7 months and I bet that the last change predates the Windows 11 jobs.

My changes to the test are kind of trivial:

--- a/browser/components/extensions/test/browser/browser_unified_extensions.js
+++ b/browser/components/extensions/test/browser/browser_unified_extensions.js
@@ -153,18 +153,19 @@ add_task(async function test_clicks_on_u
   await Promise.all(extensions.map(extension => extension.startup()));
 
   const { button, panel } = gUnifiedExtensions;
   ok(button, "expected button");
   ok(panel, "expected panel");
 
   info("open panel with primary click");
   await openExtensionsPanel();
-  ok(
-    panel.getAttribute("panelopen") === "true",
+  Assert.strictEqual(
+    panel.getAttribute("panelopen"),
+    "true",
     "expected panel to be visible"
   );
   await closeExtensionsPanel();
   ok(!panel.hasAttribute("panelopen"), "expected panel to be hidden");
 
   info("open context menu with non-primary click");
   const contextMenu = document.getElementById("toolbar-context-menu");
   const popupShownPromise = BrowserTestUtils.waitForEvent(
@@ -182,18 +183,19 @@ add_task(async function test_clicks_on_u
   // On MacOS, ctrl-click shouldn't open the panel because this normally opens
   // the context menu. We can't test anything on MacOS...
   if (AppConstants.platform !== "macosx") {
     info("open panel with ctrl-click");
     const listView = getListView();
     const viewShown = BrowserTestUtils.waitForEvent(listView, "ViewShown");
     EventUtils.synthesizeMouseAtCenter(button, { ctrlKey: true });
     await viewShown;
-    ok(
-      panel.getAttribute("panelopen") === "true",
+    Assert.strictEqual(
+      panel.getAttribute("panelopen"),
+      "true",
       "expected panel to be visible"
     );
     await closeExtensionsPanel();
     ok(!panel.hasAttribute("panelopen"), "expected panel to be hidden");
   }
 
   await Promise.all(extensions.map(extension => extension.unload()));
 });

So I don't think that has anything to do with the failure. Over to Tomislav and/or Will to see if they want to do anything here.

Flags: needinfo?(gijskruitbosch+bugs)

Oops, needinfo for comment #2.

Flags: needinfo?(wdurand)
Flags: needinfo?(tomica)

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Affects Firefox for Android]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:

relnote-firefox: --- → ?
Flags: in-testsuite?
Flags: behind-pref+

Please do not change random fields on random bugs.

relnote-firefox: ? → ---
Flags: in-testsuite?
Flags: behind-pref+
Attachment #9385925 - Attachment is obsolete: true
Summary: Intermittent TV browser/components/extensions/test/browser/browser_unified_extensions.js | single tracking bug → Intermittent browser/components/extensions/test/browser/browser_unified_extensions.js | single tracking bug
Blocks: 1905392
No longer blocks: 1905392
Depends on: 1905392

Clearing old needinfos (the underlying reason for the exception hit by the failure from comment 0 has also been fixed already by Bug 1905392, as also briefly mentioned in Bug 1905392 comment 0).

Flags: needinfo?(wdurand)
Flags: needinfo?(tomica)
See Also: → 1905392
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: