Closed Bug 1905392 Opened 3 months ago Closed 2 months ago

OriginControls.getState throws "policy.extension.tabManager is undefined" when an extension is starting up

Categories

(WebExtensions :: Frontend, defect, P3)

Product:
WebExtensions
Component:
Frontend
Type:
defect

Tracking

(firefox130 fixed)

Status:
RESOLVED FIXED
Milestone:
130 Branch
Tracking Flags:
Tracking Status
firefox130 --- fixed

People

(Reporter: robwu, Assigned: robwu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [addons-jira])

Attachments

(1 file)

Bug 1905392 - Fix OriginControls.getState for extensions during startup
48 bytes, text/x-phabricator-request
Details | Review

I just encountered a test failure, with a stack trace similar to bug 1876359.

Upon investigation, it looks like OriginControls.getState is called for an extension that is in the middle of extension startup. We should handle that gracefully instead of breaking the UI.

I'm drawing the conclusion that the extension in the test is in the middle of startup, because policy.extension being set implies that the extension has done the minimum to start up, but policy.extension.tabManager being undefined implies that the "startup" event has not fired yet, which is responsible for initializing extension.tabManager.

Blocks: 1876359
No longer depends on: 1876359
Assignee: nobody → rob
Status: NEW → ASSIGNED
Severity: -- → S4
Priority: -- → P3
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/b13620c0be9d
Fix OriginControls.getState for extensions during startup r=zombie

https://hg.mozilla.org/mozilla-central/rev/b13620c0be9d

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox130: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: