1876398 - Update AndroidX Compose BOM to 2024.03.00

Status: RESOLVED FIXED

(Firefox for Android :: General, task)

Description

[Ryan VanderMeulen [:RyanVM]]

Changelogs:

• https://developer.android.com/jetpack/androidx/releases/compose-animation#1.6.0
• https://developer.android.com/jetpack/androidx/releases/compose-foundation#1.6.0
• https://developer.android.com/jetpack/androidx/releases/compose-material#1.6.0
• https://developer.android.com/jetpack/androidx/releases/compose-runtime#1.6.0
• https://developer.android.com/jetpack/androidx/releases/compose-ui#1.6.0

Comment 1

[Ryan VanderMeulen [:RyanVM]]

This is hitting failures that a quick Google search is telling me may be related to the version of Kotlin we're using.

/builds/worker/workspace/gradle-home/caches/transforms-3/886d4caad1a9ddc90bbb8419932d068e/transformed/runtime-release/jars/lint.jar: Error: Library lint checks reference invalid APIs; these checks will be skipped!

Which seems plausible since reference-browser doesn't have any issues and it's currently on 1.9.22.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1876398 - Upgrade compose to latest version. (#5472)

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Changelogs:

• https://developer.android.com/jetpack/androidx/releases/compose-animation#1.6.1
• https://developer.android.com/jetpack/androidx/releases/compose-foundation#1.6.1
• https://developer.android.com/jetpack/androidx/releases/compose-material#1.6.1
• https://developer.android.com/jetpack/androidx/releases/compose-runtime#1.6.1
• https://developer.android.com/jetpack/androidx/releases/compose-ui#1.6.1

Comment 4

[Mihai Adrian Carare [:mcarare]]

Along with the AGP update, migrating from Swipeable to AnchoredDraggable ( docs in see also link) is also mandatory. It cannot be done before the update since the new API does not exist until 1.6.0, so it needs to be done in the same PR as the upgrade.

Comment 5

[BMO Github Automation]

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/2ba9b2bc6eae0b6c1626eb161868b4efb495c0db
[main] Bug 1876398 - Upgrade compose to latest version.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/1d08590f1813f176fcb3973443b2785640a13141
[main] Bug 1876398 - Suppressing deprecation for Swipeable.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/256fa9607e9afdfe8567747d1c6f63cbc7bf918e
[main] Bug 1876398 - Adjust y offset for new method of positioning.

Comment 6

[BMO Github Automation]

Authored by https://github.com/rvandermeulen
https://github.com/mozilla-mobile/firefox-android/commit/977e70d484937eb146d1f6ba9ce7689d87a432db
[main] Revert "Bug 1876398 - Update AndroidX Compose to version 1.6.1" because it depends on the AGP 8.3.0 update

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Reverted because the AGP 8.3.0 update had to be backed out.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

I refreshed patches post-migration and pushed to Try now that the AGP 8.3.0 bump has had some time to bake.
https://treeherder.mozilla.org/jobs?repo=try&revision=2794519650993b948890788c8bc4b5c3e139820d&group_state=expanded

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1876398 - Update AndroidX Compose BOM to 2024.03.00.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1876398 - Suppress deprecation for Swipeable.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1876398 - Adjust y offset for new method of positioning.

See https://android-review.googlesource.com/c/platform/frameworks/support/+/2701713.
y offsets are no longer reversed when the menu is near the bottom of the screen.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d701192aa6b
Update AndroidX Compose BOM to 2024.03.00. r=android-reviewers,mcarare
https://hg.mozilla.org/integration/autoland/rev/8588c6f15886
Suppress deprecation for Swipeable. r=android-reviewers,mcarare
https://hg.mozilla.org/integration/autoland/rev/7495961f88dc
Adjust y offset for new method of positioning. r=android-reviewers,mcarare

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8d701192aa6b
https://hg.mozilla.org/mozilla-central/rev/8588c6f15886
https://hg.mozilla.org/mozilla-central/rev/7495961f88dc