1981655 - URL and favicon look misaligned on Homepage "jump back in" tiles

Status: NEW

(Firefox for Android :: Homepage, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: "bad" screenshot from Firefox 142.0b6

[Tracking Requested - why for this release]: visual regression on new-tab page.

Steps to reproduce

1. Visit some site, e.g. https://www.yahoo.com
2. Open a new tab to see the Firefox for Android "home page" (new-tab page)
3. Look at the "Jump back in" tile for the tab that you opened in step 1.

Expected behavior

The favicon and URL should look nicely aligned (e.g. either vertically centered with respect to each other, or baseline-aligned)

Actual behavior

The favicon is aligned very slightly higher up than the text, which looks odd because the favicon is also taller than the text.

Device information

• Firefox version: 142.0b6, 143.0a1
• Android device model: Pixel 9 Pro XL
• Android OS version: 16

Any additional information?

This seems to be a regression in current beta/nightly with respect to current release -- Firefox 141.0.1 gives "expected behavior" (url is vertically centered next to favicon), whereas Firefox 142beta and 143nightly show "Actual Behavior"

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: "good" screenshot from Firefox 141.0.1

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: scaled-up pieced of "bad" screenshot, with red horizontal line added to show slight misalignment

Here's a zoomed in visualization to show the misalignment.

It's only off by 1-2 pixels, but even that 1-2px feels awkward (to me at least) I think because the favicon is already so much taller than the text, and hence its top edge is already so much further above the top edge of the text, and so shifting it further upward (with respect to the text) feels backwards/unusual.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: "good" screenshot of better-looking alignment in "Recently visited" section

The "recently visited" section has similarly sized text aligned with the same favicon, but the text is nicely vertically centered with respect to the favicon there, I think (see screenshot). It looks nice like this in Nightly as well as beta in this "Recently visited" section.

Only the "jump back in" section seems to have the alignment issue.

Comment 4

[Daniel Holbert [:dholbert]]

Hmm - despite current release being "good", this goes back over a year on Nightly.

Regression range:
INFO: Newest known good nightly: 2024-03-21
INFO: Oldest known bad nightly: 2024-03-22
https://hg-edge.mozilla.org/mozilla-central/pushloghtml?fromchange=9f6186fead44&tochange=5d6efea5e0bb

In there, I'm guessing this might've been from bug 1876398:
https://hg-edge.mozilla.org/mozilla-central/rev/8d701192aa6b46335ee9b08d9bf107feabd3ba0a
Ryan VanderMeulen — Bug 1876398 - Update AndroidX Compose BOM to 2024.03.00. r=android-reviewers,mcarare

That bug had another commit that adjusted the y-position of a bit of translation UI "for new method of positioning", which I assume was addressing some UI that would otherwise have shifted due to the "new method of positioning" in the AndroidX Compose update. My guess is that this bit of the home screen maybe needed a similar tweak to account for that change...

(I still have no idea how/why this doesn't affect current release, over a year later, despite affecting beta & Nightly. But maybe that's a good sign that there's something keeping release from being affected, and/or that nobody would be too bothered if this did make it to release.)

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

:mcarare, since you are the author of the regressor, bug 1876398, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox142 (beta). We have limited time to fix this, the soft freeze is in 6 days. However, the bug still isn't assigned.

:gl, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 7

[Mihai Adrian Carare [:mcarare]]

The changes in https://phabricator.services.mozilla.com/D205354 only affect the translations bottomsheet dropdown menu.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1876398