1876518 - Only the icons are displayed for Options inside the Open a new container Tab context menu option inside the Library and the Sidebar

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Found in

• 124.0a1 (2024-01-24)

Affected versions

• 122.0.1 (not default)
• 123.0b2 (not default)
• 124.0a1 (2024-01-24)

Tested platforms

• Affected platforms: Windows 10x64, macOS 12, Ubuntu 22.04
• Unaffected platforms: none

Steps to reproduce

1. Open the Library (Ctrl + Shift + H).
2. Select a random item from History and right click on it.
3. See the available options.

Expected result

• The Container strings options are displayed.

Actual result

• Only the icons for the container option are displayed.

Regression

• Mozregression pushlog:
  Last good revision: 4009f34666067d6e1c26ce4acf25ced573d8c09d
  First bad revision: 2579a5934476edbd55f206ec87d13582ec85a5ca
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4009f34666067d6e1c26ce4acf25ced573d8c09d&tochange=2579a5934476edbd55f206ec87d13582ec85a5ca

Additional notes

• Attached a screenshot.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:eemeli, since you are the author of the regressor, bug 1814969, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Eemeli Aro [:eemeli]]

Attachment: Bug 1876518 - Include missing FTL reference in places.xhtml. r?mconley

Comment 3

[Eemeli Aro [:eemeli]]

Ah, I'd missed that the submenu's used here as well.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bb23716a8c9
Include missing FTL reference in places.xhtml. r=places-reviewers,Standard8

Comment 6

[Donal Meehan [:dmeehan]]

Tracking for 122, it's got a dup and I've seen some chatter online about this.
We have the planned dot release scheduled to build on 2024-02-05. If this can get a beta and a release uplift request when ready.

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5bb23716a8c9

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Hello! I verified today that the issue is no longer reproducible inside the Library window with Firefox 124.0a1 (2024-01-29) on Windows 10x64, macOS 12 and Ubuntu 22.

However I found out that the issue is also reproducible inside the Sidebar with the same Firefox version. Should we reopen this issue or file another one? Thank you!

Comment 9

[Eemeli Aro [:eemeli]]

Let's reopen. I'll patch this too.

Comment 10

[Eemeli Aro [:eemeli]]

Attachment: Bug 1876518 - Ensure that contextual-identity.ftl is always available for the user context menu. r?Standard8!

Rather than playing whack-a-mole to proactively account for all the places where the menu might show up, let's just make sure its messages are always available.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51cfd5dc22d9
Ensure that contextual-identity.ftl is always available for the user context menu. r=Standard8,places-reviewers

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/51cfd5dc22d9

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:eemeli, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 14

[Eemeli Aro [:eemeli]]

Attachment: Bug 1876518 - Include missing FTL reference in places.xhtml.

Original Revision: https://phabricator.services.mozilla.com/D199843

Comment 15

[Eemeli Aro [:eemeli]]

Attachment: Bug 1876518 - Ensure that contextual-identity.ftl is always available for the user context menu.

Rather than playing whack-a-mole to proactively account for all the places where the menu might show up, let's just make sure its messages are always available.

Original Revision: https://phabricator.services.mozilla.com/D200156

Comment 16

[Eemeli Aro [:eemeli]]

Attachment: Bug 1876518 - Include missing FTL reference in places.xhtml.

Original Revision: https://phabricator.services.mozilla.com/D199843

Comment 17

[Eemeli Aro [:eemeli]]

Attachment: Bug 1876518 - Ensure that contextual-identity.ftl is always available for the user context menu.

Rather than playing whack-a-mole to proactively account for all the places where the menu might show up, let's just make sure its messages are always available.

Original Revision: https://phabricator.services.mozilla.com/D200156

Comment 18

[Phabricator Automation]

Uplift Approval Request

• Is Android affected?: no
• String changes made/needed: None
• Steps to reproduce for manual QE testing: 1. Open the sidebar or the places window. 2. Right click on an item, and hover over "Open in New Container Tab". 3. Observe that the default container items have names.
• Risk associated with taking this patch: Minimal
• Needs manual QE test: yes
• User impact if declined: "Open in New Container Tab" menu contains only icons in library & sidebar
• Fix verified in Nightly: yes
• Code covered by automated testing: no
• Explanation of risk level: Adds a single MozXULElement.insertFTLIfNeeded() call to the menu's creator function

Comment 19

[Donal Meehan [:dmeehan]]

(In reply to Donal Meehan [:dmeehan] from comment #6)

Tracking for 122, it's got a dup and I've seen some chatter online about this.
We have the planned dot release scheduled to build on 2024-02-05. If this can get a beta and a release uplift request when ready.

:eemeli could you add a release uplift request too?
We can include this in the planned Fx122 dot release

Comment 20

[Eemeli Aro [:eemeli]]

Attachment: Bug 1876518 - Include missing FTL reference in places.xhtml.

Original Revision: https://phabricator.services.mozilla.com/D199843

Comment 21

[Eemeli Aro [:eemeli]]

Attachment: Bug 1876518 - Ensure that contextual-identity.ftl is always available for the user context menu.

Rather than playing whack-a-mole to proactively account for all the places where the menu might show up, let's just make sure its messages are always available.

Original Revision: https://phabricator.services.mozilla.com/D200156

Comment 22

[Phabricator Automation]

Uplift Approval Request

• Code covered by automated testing: no
• User impact if declined: "Open in New Container Tab" menu contains only icons in library & sidebar
• Fix verified in Nightly: yes
• Explanation of risk level: Adds a single MozXULElement.insertFTLIfNeeded() call to the menu's creator function
• Steps to reproduce for manual QE testing: 1. Open the sidebar or the places window. 2. Right click on an item, and hover over "Open in New Container Tab". 3. Observe that the default container items have names.
• Needs manual QE test: yes
• Risk associated with taking this patch: Minimal
• Is Android affected?: no
• String changes made/needed: None

Comment 23

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 124.0a1 (20240201095346) on Windows 11x64, macOS 12, and Ubuntu 22. The container items have their names displayed inside the Library window and the Sidebar.

Comment 24

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/39a24ad65fa1

Comment 25

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/4981454a7cb6

Comment 26

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 123.0b6 (20240201145552) from comment 25 on Windows 11x64, macOS 12 and Ubuntu 22. The container items have their names displayed inside the Library window and the Sidebar.

Comment 27

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/be6c05ab6fab
https://hg.mozilla.org/releases/mozilla-release/rev/397b0445dae0

Comment 28

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 122.0.1 (20240205133611) on Windows 10x64, macOS 14 and Ubuntu 22. The container items have their names displayed inside the Library window and the Sidebar.