1814969 - ContextualIdentityService has browser/ dependencies

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P5)

Description

[[e-mail]]

Because other toolkit components depended on the ContextualIdentityService bug 1285889 moved most of ContextualIdentityService.jsm from browser/components/contextualidentity into tookit/components/contextualidentity [sic] however the images and strings still live in browser/; is that the correct place for them?

Comment 1

[[e-mail]]

To clarify, I'm asking because the component shows up in other toolkit applications, and the only reason it doesn't work is the lack of strings. (Lack of icons is less of a problem.) If other applications want to use the component how would they go about providing the strings?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:timhuang, since you are the author of the regressor, bug 1285889, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Tim Huang[:timhuang]]

Luke, I think you are a better person to answer this than me. :)

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Comment 5

[Frederik Braun [:freddy]]

I think Maxx is the person who most recently worked on it?
Anyhow, I think it makes sense to move the files around. We don't seem to require them to be where they are (afaiu).

Comment 6

[Daniel Veditz [:dveditz]]

This really isn't "DOM: Security" code, but I can't figure out where else it ought to go.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1285889

Comment 8

[Maxx Crawford [:maxx]]

:(In reply to Frederik Braun [:freddy] from comment #5)

I think Maxx is the person who most recently worked on it?
Anyhow, I think it makes sense to move the files around. We don't seem to require them to be where they are (afaiu).

I've not been working with it, but I may know who has! Danny (:sdk) is help maintain the add-on, and may be able to help.

Comment 9

[Danny Colin [:sdk]]

(In reply to [e-mail] from comment #1)

To clarify, I'm asking because the component shows up in other toolkit applications, and the only reason it doesn't work is the lack of strings. (Lack of icons is less of a problem.) If other applications want to use the component how would they go about providing the strings?

I don't know why they kept the images/css there. My guess would be that it's only what they needed for the indicator in the front-end. What strings are you referring to? I only see icons in browser/.

Comment 10

[[:fabrice] Fabrice Desré]

(In reply to Danny Colin [:sdk] from comment #9)

I don't know why they kept the images/css there. My guess would be that it's only what they needed for the indicator in the front-end. What strings are you referring to? I only see icons in browser/.

These strings: https://searchfox.org/mozilla-central/rev/0ddb7a38cdbba30df8f19549f678a22fa16967d1/browser/locales/en-US/chrome/browser/browser.properties#422 are referenced from this bundle: https://searchfox.org/mozilla-central/rev/0ddb7a38cdbba30df8f19549f678a22fa16967d1/toolkit/components/contextualidentity/ContextualIdentityService.sys.mjs#15

Comment 11

[Eemeli Aro [:eemeli]]

I started working on this at it'll also allow for removing a bunch of strings from mobile/android/:
https://treeherder.mozilla.org/jobs?repo=try&revision=ee3b2f73e4e34577f391b55a60c2f3c82e8fd83a

Any recommendations for whom I could/should ask for a review?

Comment 12

[Eemeli Aro [:eemeli]]

Attachment: Bug 1814969: Migrate ContextualIdentityService strings to Fluent

This includes a containers.json version increment and the necessary migration,
as the StringBundle identifiers are replaced with a Fluent reference.

As it's not possible to filter the attributes that are applied with DOM localization,
the code in utilityOverlay.js is a little clumsy. The non-acceskey versions are needed
due to bug 1297738, i.e. the long-press menu available from the tab bar down arrow.

Previously, the "Manage containers" menu item and its accesskey were defined in two places.
These are here combined into one.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2579a5934476
Migrate ContextualIdentityService strings to Fluent r=geckoview-reviewers,fluent-reviewers,mconley,owlish,flod

Comment 14

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2579a5934476