1876532 - The zoom transition is janky when fast zooming in and out on the map using the mouse wheel at airbnb.com

Status: RESOLVED DUPLICATE of bug 1887161

(Core :: Performance, defect)

Description

[Raul Bucata]

Attachment: 20240125_160443.mp4

Environment:
Operating System: Windows 10 PRO x64
Firefox version: Firefox Nightly 124.0a1 (2024-01-24)

Preconditions:
Clean profile
Mouse with wheel scroll

Steps to reproduce:

1. Navigate to : https://www.airbnb.com/
2. Click on the "Show map" button.
3. Zoom in and out using the mouse wheel as fast as possible.
4. Observe the result.

Expected Behavior:
The zoom transition is smooth

Actual Behavior:

The zoom transition is janky

Notes:

• Reproducible regardless of the status of ETP
• Reproducible on the latest build of Firefox Nightly and Release
• Works as expected using Chrome
• Does not reproduce using the buttons on the page
• Screenrec attached
• Issue found during WebCompat team [Top100] websites testing

Comment 1

[Ksenia Berezina [:ksenia]]

Hi Raul, could you please capture a profile?

Comment 2

[Raul Bucata]

Sure. Here is the performance profile

Comment 3

[Ksenia Berezina [:ksenia]]

Thank you, moving this to Performance for further investigation.

Comment 4

[Markus Stange [:mstange]]

The performance profile is showing a lot of time in mozilla::nsRFPService::RandomizePixels. Do you have privacy.resistFingerprinting turned on?

Comment 5

[Raul Bucata]

Hi Markus. The profile in which this was tested was a new, clean profile, with no altered configs (privacy.resistFingerprinting turned off by default). I can make a new performance profile if you'd like, in another new clean profile.

Comment 6

[Markus Stange [:mstange]]

Please do. Reading the code, I'm pretty sure we only want to call RandomizePixels when privacy.resistFingerprinting is on. If it's called with the pref off, then there must be a bug somewhere and we need to fix it.

Comment 7

[Gregory Pappas [:gregp]]

Maybe the profile was recorded in a private window? According to bug 1834622, canvas randomization is enabled in private windows.

Comment 8

[Tom Ritter [:tjr]]

That is correct, my suspicion is that this was recorded in a Private Window which enables Fingerprinting Protection (FPP). If ETP Strict was enabled, FPP would be enabled in normal windows also.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

This bug was moved into the Performance component.

:rbucata, could you make sure the following information is on this bug?

• ✅ For slowness or high CPU usage, capture a profile with http://profiler.firefox.com/, upload it and share the link here.
• For memory usage issues, capture a memory dump from about:memory and attach it to this bug.
• Troubleshooting information: Go to about:support, click "Copy raw data to clipboard", paste it into a file, save it, and attach the file here.

If the requested information is already in the bug, please confirm it is recent.

Thank you.

Comment 10

[Julien Wajsberg [:julienw]]

The Performance Impact Calculator has determined this bug's performance impact to be high. If you'd like to request re-triage, you can reset the Performance Impact flag to "?" or needinfo the triage sheriff.

Platforms: Windows
Impact on site: Causes noticeable jank
Websites affected: Major
[x] Affects animation smoothness
[x] Able to reproduce locally

Note: I compared Chrome and Firefox on this URL, Chrome is noticeably faster. (Linux here)
I was on my normal profile though, I'll try again later on a clean profile.

Comment 11

[Raul Bucata]

Attachment: about.support.airbnb.txt

Comment 12

[Raul Bucata]

Attachment: memory-report-airbnb.json

Comment 13

[Raul Bucata]

Here is a freshly capture performance profile, in a new clean profile, with ETP turned off, and in normal browsing mode: https://share.firefox.dev/3VqPUvm

Info requested from the bot:

• Memory report attached
• about:support info attached

Comment 14

[Markus Stange [:mstange]]

Is the performance better in a regular window?

Comment 15

[Julien Wajsberg [:julienw]]

Here is a profile on my machine in a regular window: https://share.firefox.dev/43sXPKE (there's some profiler overhead...).
I see this more if I put the map in full screen (reducing the sidebar with the list of options)

The performance is better in a regular window than in a private window indeed: in the private window I don't need to put the map in full screen to see smoothness problem.

Comment 16

[Markus Stange [:mstange]]

I've filed bug 1887161 as a more tightly-scoped issue about GenerateCanvasKeyFromImageData being slow.

Comment 17

[Markus Stange [:mstange]]

I've decided to mark this bug as a duplicate of bug 1887161 because there's nothing else to do in this bug for now.