1876574 - Add SameSite bit to partition-key origin attribute for first-party partitioning

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task)

Description

[Benjamin VanderSloot [:bvandersloot]]

I think this has to be a separate task outside of what we currently have bugged out for CHIPS. This will not be used for Storage, which doesn't have a concept of first-party partitioning.

Comment 1

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1876574 - Add SameSite bit to partition-key origin attribute for first-party partitioning - r=timhuang!

This patch is a no-op for observable functionality. All it does is add a bit to the partitionKey for OA, and then adds plumbing to be able to set it, and where it is required, sets it to false.
This is serialized identically to the absence of the bit, so nothing changes at all.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc547125fda9
Add SameSite bit to partition-key origin attribute for first-party partitioning - r=timhuang

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages @ toolkit/components/resistfingerprinting/nsRFPService.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/dd4ea6fd487cdd13b3e9274caf128a106928dc92

Push with failures

Failure log -> ERROR - /builds/worker/checkouts/gecko/toolkit/components/resistfingerprinting/nsRFPService.cpp

Comment 4

[Benjamin VanderSloot [:bvandersloot]]

Looks like there was an upstream change on March 27 that caused a conflict. Rebasing, building, and trying again.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58576ed7eb22
Add SameSite bit to partition-key origin attribute for first-party partitioning - r=timhuang

Comment 6

[Serban Stanca [:SerbanS]]

Backed out for causing multiple failure.

• Backout link

---

• Push with failures - xpcshell failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | caps/tests/unit/test_oa_partitionKey_pattern.js | xpcshell return code: 0

---

• Push with failures - devtools failures
• Failure Log
• Failure line: [1075] Assertion failure: !aParentContext->IsInProcess(), at /builds/worker/checkouts/gecko/toolkit/components/antitracking/StorageAccessAPIHelper.cpp:478

---

• Push with failures - mochitests failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_installtrigger_install.js | Test timed out -

Comment 7

[Benjamin VanderSloot [:bvandersloot]]

Same as https://bugzilla.mozilla.org/show_bug.cgi?id=1876575#c11.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/704e94d28ad7
Add SameSite bit to partition-key origin attribute for first-party partitioning - r=timhuang

Comment 9

[Cristian Tuns]

Backed out for causing multiple failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | TestStoragePrincipalHelper.TestGetPrincipalCookieBehavior5 | Value of: testPrincipal->OriginAttributesRef().mPartitionKey.EqualsLiteral( "(https,example.org)")

Wpt failures on Android: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f00e9fde550f6ecbd0b8655d8ad34ee5f9a38770&searchStr=android%2Cwpt&selectedTaskRun=NRklJ9gCSs2amn5Lc0fN5g.0

Comment 10

[Benjamin VanderSloot [:bvandersloot]]

Same as https://bugzilla.mozilla.org/show_bug.cgi?id=1876575#c14

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8cda85eda3d
Add SameSite bit to partition-key origin attribute for first-party partitioning - r=timhuang

Comment 12

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/c8cda85eda3d