1876590 - Removing use of platform.ini from BuildID mismatch detection code

Status: RESOLVED FIXED

(Core :: IPC, enhancement)

Description

[:gerard-majax]

We introduced it in bug 1651133, but this is not cool and it looks like we still need to do this. I have some code that is able to read it from a binary's dedicated section which would allow us to rely on this

Comment 1

[:gerard-majax]

Attachment: Bug 1876590 - Place gToolkitBuildID in a specific section r?#build!

Comment 2

[:gerard-majax]

Attachment: WIP: Bug 1876590 - Locally apply PR #391 for goblin

Depends on D199658

Comment 3

[:gerard-majax]

Attachment: Bug 1876590 - Add buildid_reader crate r?afranchuk!

Depends on D199709

Comment 4

[:gerard-majax]

Attachment: Bug 1876590 - Use buildid_reader crate for verification of mismatch r?jld!

Depends on D199710

Comment 5

[:gerard-majax]

Attachment: Bug 1876590 - Undo platform.ini packaging changes r?nalexander!

This reverts commit a70f59c7d9da728a355a38dd4dbbd33d5730d442.

Depends on D199711

Comment 6

[:gerard-majax]

Attachment: Bug 1876590 - Add gtest for buildid reading from shared lib r?afranchuk!

Depends on D199853

Comment 7

[:gerard-majax]

Unfortunately, I dont see how we can keep some of the telemetry tests that were relying on changing platform.ini content, doing the same with libxul sounds much more complicated.

Comment 8

[:gerard-majax]

Attachment: Bug 1876590 - Update browser chome test for buildid_reader crate r?jld!

Removing tests because we cannot change platform.ini file anymore

Depends on D201381

Comment 9

[:gerard-majax]

Attachment: WIP: Bug 1876590 - Update goblin and deps

Depends on D199710

Comment 10

[:gerard-majax]

Attachment: WIP: Bug 1876590 - MERGE

Depends on D203736

Comment 11

[:gerard-majax]

Attachment: WIP: Bug 1876590 - Update goblin dependency for buildid_reader

Depends on D199710

Comment 12

[:gerard-majax]

Attachment: Bug 1876590 - Vendor goblin crate for 0.8.1 for buildid_reader r?#build!

Depends on D199658

Comment 13

[:gerard-majax]

Attachment: WIP: Bug 1876590 - Workaround for bug 1893976

Depends on D207960

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0e5aee15a6a
Place gToolkitBuildID in a specific section r=firefox-build-system-reviewers,nalexander,glandium

Comment 15

[Iulian Moraru]

Backed out for causing multiple failures.

• Push with failures

• Failure log for gv-junit jobs

• Failure log for xpcshell jobs

• Backout link

Comment 16

[:gerard-majax]

that makes no sense to me, especially the android failures, the code is not used there

Comment 17

[:gerard-majax]

(In reply to :gerard-majax from comment #16)

that makes no sense to me, especially the android failures, the code is not used there

ok so it's failing at https://searchfox.org/mozilla-central/rev/7a8904165618818f73ab7fc692ace4a57ecd38c9/toolkit/crashreporter/test/unit_ipc/test_content_annotation.js#26

Comment 18

[Iulian Moraru]

Found that this also causes the following failures:

• bc failures
• another xpcshell job, example 1
• another xpcshell job, example 2
  I hope this helps.

Comment 19

[:gerard-majax]

Thanks, it indeed helped and it looks like my changes highlighted some subtile bug in how we were processing crash annotations

I have a fix tested on try for that https://treeherder.mozilla.org/jobs?repo=try&revision=7dc71f8e5628f43a18b8c22d720d12165e01fb09 and it looks to be good (no more android gv unit failures for example)

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c75ebb5f3a80
Place gToolkitBuildID in a specific section r=firefox-build-system-reviewers,nalexander,glandium
https://hg.mozilla.org/integration/autoland/rev/115753252616
Vendor goblin crate for 0.8.1 for buildid_reader r=supply-chain-reviewers,glandium
https://hg.mozilla.org/integration/autoland/rev/55cc3acc9297
Add buildid_reader crate r=afranchuk
https://hg.mozilla.org/integration/autoland/rev/0b07a6f1beac
Add gtest for buildid reading from shared lib r=afranchuk
https://hg.mozilla.org/integration/autoland/rev/6d978847d7dd
Use buildid_reader crate for verification of mismatch r=jld
https://hg.mozilla.org/integration/autoland/rev/2cd2cc626c44
Undo platform.ini packaging changes r=nalexander
https://hg.mozilla.org/integration/autoland/rev/9ac3a93622c8
Update browser chome test for buildid_reader crate r=jld

Comment 21

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c75ebb5f3a80
https://hg.mozilla.org/mozilla-central/rev/115753252616
https://hg.mozilla.org/mozilla-central/rev/55cc3acc9297
https://hg.mozilla.org/mozilla-central/rev/0b07a6f1beac
https://hg.mozilla.org/mozilla-central/rev/6d978847d7dd
https://hg.mozilla.org/mozilla-central/rev/2cd2cc626c44
https://hg.mozilla.org/mozilla-central/rev/9ac3a93622c8

Comment 22

[tszentpeteri]

Backed out for causing gtest failures related to BuildIDReader.ReadFromRealLib.

• Backout link
• Push with failures
• Failure Log link
• Failure log:

[task 2024-05-31T01:06:24.049Z] 01:06:24     INFO -  TEST-START | BuildIDReader.ReadFromRealLib
[task 2024-05-31T01:06:24.049Z] 01:06:24     INFO -  [ERROR buildid_reader::reader] BuildIdReader::read_string_build_id failed to read raw build id with error NS_ERROR_NOT_AVAILABLE
[task 2024-05-31T01:06:24.050Z] 01:06:24     INFO -  [ERROR buildid_reader] read_toolkit_buildid_from_file failed to read string buiild id from note ".note.moz.toolkit-build-id" with error NS_ERROR_NOT_AVAILABLE
[task 2024-05-31T01:06:24.051Z] 01:06:24  WARNING -  TEST-UNEXPECTED-FAIL | BuildIDReader.ReadFromRealLib | Value of: ((bool)(__builtin_expect(!!(!NS_FAILED_impl(rv)), 1)))
[task 2024-05-31T01:06:24.051Z] 01:06:24     INFO -    Actual: false
[task 2024-05-31T01:06:24.051Z] 01:06:24     INFO -  Expected: true
[task 2024-05-31T01:06:24.051Z] 01:06:24     INFO -  Error reading from libxul.so: 80040111
[task 2024-05-31T01:06:24.052Z] 01:06:24     INFO -   @ /builds/worker/checkouts/gecko/toolkit/library/gtest/TestBuildIDReader.cpp:153
[task 2024-05-31T01:06:24.052Z] 01:06:24  WARNING -  TEST-UNEXPECTED-FAIL | BuildIDReader.ReadFromRealLib | test completed (time: 0ms)
[task 2024-05-31T01:06:24.052Z] 01:06:24     INFO -  TEST-START | BuildIDReader.ReadFromNSAppRunner
[task 2024-05-31T01:06:24.052Z] 01:06:24     INFO -  [ERROR buildid_reader::reader] BuildIdReader::read_string_build_id failed to read raw build id with error NS_ERROR_NOT_AVAILABLE
[task 2024-05-31T01:06:24.052Z] 01:06:24     INFO -  [ERROR buildid_reader] read_toolkit_buildid_from_file failed to read string buiild id from note ".note.moz.toolkit-build-id" with error NS_ERROR_NOT_AVAILABLE
[task 2024-05-31T01:06:24.052Z] 01:06:24  WARNING -  TEST-UNEXPECTED-FAIL | BuildIDReader.ReadFromNSAppRunner | Value of: ((bool)(__builtin_expect(!!(!NS_FAILED_impl(rv)), 1)))
[task 2024-05-31T01:06:24.052Z] 01:06:24     INFO -    Actual: false
[task 2024-05-31T01:06:24.052Z] 01:06:24     INFO -  Expected: true
[task 2024-05-31T01:06:24.052Z] 01:06:24     INFO -  Error reading from libxul.so: 80040111
[task 2024-05-31T01:06:24.052Z] 01:06:24     INFO -   @ /builds/worker/checkouts/gecko/toolkit/library/gtest/TestBuildIDReader.cpp:170
[task 2024-05-31T01:06:24.052Z] 01:06:24  WARNING -  TEST-UNEXPECTED-FAIL | BuildIDReader.ReadFromNSAppRunner | test completed (time: 0ms)
[task 2024-05-31T01:06:24.052Z] 01:06:24     INFO -  TEST-START | PHC.TestPHCAllocations

Comment 23

[pstanciu]

Hello, backout merged to central link

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4747f50c91bb
Place gToolkitBuildID in a specific section r=firefox-build-system-reviewers,nalexander,glandium
https://hg.mozilla.org/integration/autoland/rev/daebbff95c49
Vendor goblin crate for 0.8.1 for buildid_reader r=supply-chain-reviewers,glandium
https://hg.mozilla.org/integration/autoland/rev/2b56abfce097
Add buildid_reader crate r=afranchuk
https://hg.mozilla.org/integration/autoland/rev/e56673df749c
Add gtest for buildid reading from shared lib r=afranchuk
https://hg.mozilla.org/integration/autoland/rev/dd6f8d15a5b4
Use buildid_reader crate for verification of mismatch r=jld
https://hg.mozilla.org/integration/autoland/rev/335f1af9e115
Undo platform.ini packaging changes r=nalexander
https://hg.mozilla.org/integration/autoland/rev/82bfb0e9296e
Update browser chome test for buildid_reader crate r=jld

Comment 25

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4747f50c91bb
https://hg.mozilla.org/mozilla-central/rev/daebbff95c49
https://hg.mozilla.org/mozilla-central/rev/2b56abfce097
https://hg.mozilla.org/mozilla-central/rev/e56673df749c
https://hg.mozilla.org/mozilla-central/rev/dd6f8d15a5b4
https://hg.mozilla.org/mozilla-central/rev/335f1af9e115
https://hg.mozilla.org/mozilla-central/rev/82bfb0e9296e