1899976 - error[E0425]: cannot find value `MAX_BUFFER_READ` in this scope

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Petr Sumbera]

Steps to reproduce:

Build on Solaris fails with:

18:02.59    Compiling l10nregistry v0.3.0 (/builds/psumbera/mozilla-central-build/intl/l10n/rust/l10nregistry-rs)
18:02.84 error[E0425]: cannot find value `MAX_BUFFER_READ` in this scope
18:02.84   --> toolkit/library/buildid_reader/src/reader.rs:42:30
18:02.84    |
18:02.84 42 |         let mut buffer = [0; MAX_BUFFER_READ];
18:02.84    |                              ^^^^^^^^^^^^^^^ not found in this scope
18:02.85 error[E0425]: cannot find value `MAX_BUFFER_READ` in this scope
18:02.85   --> toolkit/library/buildid_reader/src/reader.rs:44:109
18:02.85    |
18:02.85 44 |             error!("BuildIdReader::read_raw_build_id failed to read exact buffer of size {} with error {}", MAX_BUFFER_READ, e);
18:02.86    |                                                                                                             ^^^^^^^^^^^^^^^ not found in this scope

The first bad revision is:
changeset: 741001:55cc3acc9297
user: Alexandre Lissy <[e-mail]>
date: Thu May 30 07:41:52 2024 -0700
description:
Bug 1876590 - Add buildid_reader crate r=afranchuk

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Internationalization' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:gerard-majax, since you are the author of the regressor, bug 1876590, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[:gerard-majax]

Unfortunately, i dont know Solaris, you will have to look into bug 1876590 and help me there ; do they use same Elf as linux or something else?

Comment 4

[:gerard-majax]

If it's just Elf, then you can just add , target_os = "solaris" in all the places where we have it in buildid_reader crate

Comment 5

[Petr Sumbera]

This helps. But isn't there some generic UNIX/POSIX tareget? There are also for sure BSDs and maybe others?

--- a/toolkit/library/buildid_reader/src/reader.rs      Thu Oct 05 00:56:26 2023 -0700
+++ b/toolkit/library/buildid_reader/src/reader.rs      Fri May 31 01:58:23 2024 -0700
@@ -15,7 +15,7 @@

 use log::{error, trace};

-#[cfg(any(target_os = "android", target_os = "linux"))]
+#[cfg(any(target_os = "android", target_os = "linux", target_os = "solaris"))]
 const MAX_BUFFER_READ: usize = std::mem::size_of::<goblin::elf::header::Header>();

 #[cfg(target_os = "windows")]
@@ -126,7 +126,7 @@
 #[cfg(target_os = "windows")]
 pub mod windows;

-#[cfg(any(target_os = "android", target_os = "linux"))]
+#[cfg(any(target_os = "android", target_os = "linux", target_os = "solaris"))]
 pub mod linux;

 #[cfg(any(target_os = "macos", target_os = "ios"))]

Comment 6

[:gerard-majax]

Can you verify mach gtest "BuildIDReader.*" after this?

Comment 7

[Petr Sumbera]

I'm afraid that mach gtest doesn't work on Solaris now.

Comment 8

[:gerard-majax]

(In reply to Petr Sumbera from comment #7)

I'm afraid that mach gtest doesn't work on Solaris now.

too bad, I'll add your changed in my patches, i got backed out because breaking on universal binaries on macOS, so I have to reland anywway.

Do you know how much is broken for mach gtest on Solaris? I would feel better if we could verify this on that platform instead it's going to be a shot in the dark and it might fail at the worst moment for your users.

Comment 9

[:gerard-majax]

i tried building myself but there are many things to fix, including pkg install rust that installs a way too old version. I'm going to just default to Elf parsing and that should unblock, but i cannot unfortunately make sure this is all OK.

Comment 10

[:gerard-majax]

Marking as fixed because the latest patch for bug 1876590 should properly fallback to Elf parsing on that platform and it should land in a matter of hours now, feel free to reopen.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

This bug has been marked as a regression. Setting status flag for Nightly to affected.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1876590

Comment 13

[:gerard-majax]

gaston told me tests are broken also on openbsd, and it's because of https://github.com/quinn-rs/quinn/issues/1877 which you filed :)