Closed Bug 1876694 Opened 1 year ago Closed 1 year ago

Add preference to make Rules view enter key move focus to next input

Categories

(DevTools :: Inspector: Rules, task)

Product:
DevTools
Component:
Inspector: Rules
Type:
task

Tracking

(firefox122 fixed, firefox123 fixed, firefox124 fixed)

Status:
RESOLVED FIXED
Milestone:
124 Branch
Tracking Flags:
Tracking Status
firefox122 --- fixed
firefox123 --- fixed
firefox124 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(3 files, 4 obsolete files)

Bug 1876694 - [devtools] Add preference to make Rules view enter key move focus to next input. r=#devtools-reviewers.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1876694 - [devtools] Add preference to make Rules view enter key move focus to next input. .
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review
Bug 1876694 - [devtools] Add preference to make Rules view enter key move focus to next input. .
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-release+
Details | Review

It looks like some people are so used to Enter moving the focus that the change made in Bug 1861674 is quite frustrating for them.
Let's have a pref they can flip to get the previous behavior

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Blocks: 1877457
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a3dd43748dcd [devtools] Add preference to make Rules view enter key move focus to next input. r=devtools-reviewers,ochameau.

https://hg.mozilla.org/mozilla-central/rev/a3dd43748dcd

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox124: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
Attachment #9377337 - Flags: approval-mozilla-beta?

Uplift Approval Request

  • Is Android affected?: no
  • Code covered by automated testing: yes
  • Explanation of risk level: devtools only, covered by mochitest
  • String changes made/needed: -
  • Risk associated with taking this patch: low
  • Needs manual QE test: no
  • User impact if declined: this offers a preference to roll back a keyboard behavior change in the Inspector that people are frustrated of
  • Fix verified in Nightly: no
  • Steps to reproduce for manual QE testing: -
Attachment #9377339 - Flags: approval-mozilla-release?

Uplift Approval Request

  • Is Android affected?: no
  • Code covered by automated testing: yes
  • String changes made/needed: -
  • Explanation of risk level: devtools only, covered by mochitest
  • Needs manual QE test: no
  • Risk associated with taking this patch: low
  • Fix verified in Nightly: no
  • Steps to reproduce for manual QE testing: -
  • User impact if declined: this offers a preference to roll back a keyboard behavior change in the Inspector that people are frustrated by
Attachment #9377337 - Attachment is obsolete: true
Attachment #9377337 - Flags: approval-mozilla-beta?
Attachment #9377339 - Attachment is obsolete: true
Attachment #9377339 - Flags: approval-mozilla-release?
Attachment #9377642 - Flags: approval-mozilla-beta?
Attachment #9377646 - Flags: approval-mozilla-release?
Attachment #9377642 - Attachment is obsolete: true
Attachment #9377642 - Flags: approval-mozilla-beta?
Attachment #9377646 - Attachment is obsolete: true
Attachment #9377646 - Flags: approval-mozilla-release?
Attachment #9377668 - Flags: approval-mozilla-beta?
Attachment #9377671 - Flags: approval-mozilla-release?
Attachment #9377668 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9377671 - Flags: approval-mozilla-release? → approval-mozilla-release+
Blocks: 1878490
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: