Closed Bug 1877457 Opened 5 months ago Closed 4 months ago

Default devtools.inspector.rule-view.focusNextOnEnter to true

Categories

(DevTools :: Inspector: Rules, task)

task

Tracking

(firefox122 fixed, firefox123 fixed, firefox124 fixed)

RESOLVED FIXED
124 Branch
Tracking Status
firefox122 --- fixed
firefox123 --- fixed
firefox124 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(6 files, 4 obsolete files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

We got many feedback (e.g. on https://fxdx.dev/rules-view-enter-key/) of people frustrated by the new behavior since it's been there for a very long time (ever?) and it works that way in every browser devtools. Hence, we should revert to the original behavior (pre Bug 1861674).
It's still nice to have the pref for people who want the new behavior

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7d511dc53852
[devtools] Default devtools.inspector.rule-view.focusNextOnEnter to true. r=devtools-reviewers,ochameau.
https://hg.mozilla.org/integration/autoland/rev/959c3318d5c3
[devtools] Remove ruleview-kbd-enter-notice. r=devtools-reviewers,ochameau.
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
Attachment #9377643 - Flags: approval-mozilla-beta?
Attachment #9377644 - Flags: approval-mozilla-beta?

Uplift Approval Request

  • Steps to reproduce for manual QE testing: -
  • Risk associated with taking this patch: low
  • Needs manual QE test: no
  • User impact if declined: This rolls back a keyboard behavior change in the Inspector that people are really frustrated with, as it changes a very old, standard-wide, pattern. If declined, people might switch to other browser devtools to develop/debug their websites
  • Fix verified in Nightly: no
  • Code covered by automated testing: yes
  • Explanation of risk level: devtools only, basically backs out changes that were made 2 versions ago
  • Is Android affected?: no
  • String changes made/needed: -
Attachment #9377647 - Flags: approval-mozilla-release?
Attachment #9377648 - Flags: approval-mozilla-release?

Uplift Approval Request

  • String changes made/needed: -
  • Is Android affected?: no
  • Needs manual QE test: no
  • Risk associated with taking this patch: low
  • Steps to reproduce for manual QE testing: -
  • Explanation of risk level: devtools only, basically backs out changes that were made 2 versions ago
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • User impact if declined: This rolls back a keyboard behavior change in the Inspector that people are really frustrated with, as it changes a very old, standard-wide, pattern. If declined, people might switch to other browser devtools to develop/debug their websites
Attachment #9377648 - Attachment is obsolete: true
Attachment #9377648 - Flags: approval-mozilla-release?
Attachment #9377643 - Attachment is obsolete: true
Attachment #9377643 - Flags: approval-mozilla-beta?
Attachment #9377647 - Attachment is obsolete: true
Attachment #9377647 - Flags: approval-mozilla-release?
Attachment #9377644 - Attachment is obsolete: true
Attachment #9377644 - Flags: approval-mozilla-beta?
Attachment #9377669 - Flags: approval-mozilla-beta?
Attachment #9377670 - Flags: approval-mozilla-beta?

Uplift Approval Request

  • Code covered by automated testing: yes
  • User impact if declined: This rolls back a keyboard behavior change in the Inspector that people are really frustrated with, as it changes a very old, browsers-wide, pattern. If declined, people might switch to other browser devtools to develop/debug their websites
  • Fix verified in Nightly: no
  • Explanation of risk level: devtools only, basically backs out changes that were made 2 versions ago
  • Steps to reproduce for manual QE testing: -
  • Needs manual QE test: no
  • Risk associated with taking this patch: low
  • Is Android affected?: no
  • String changes made/needed: -
Attachment #9377672 - Flags: approval-mozilla-release?
Attachment #9377673 - Flags: approval-mozilla-release?

Uplift Approval Request

  • Is Android affected?: no
  • String changes made/needed: -
  • Steps to reproduce for manual QE testing: -
  • Needs manual QE test: no
  • Risk associated with taking this patch: low
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • User impact if declined: This rolls back a keyboard behavior change in the Inspector that people are really frustrated with, as it changes a very old, browsers-wide, pattern. If declined, people might switch to other browser devtools to develop/debug their websites
  • Explanation of risk level: devtools only, basically backs out changes that were made 2 versions ago
Attachment #9377669 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9377670 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9377673 - Flags: approval-mozilla-release? → approval-mozilla-release+
Attachment #9377672 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: