1877457 - Default devtools.inspector.rule-view.focusNextOnEnter to true

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

We got many feedback (e.g. on https://fxdx.dev/rules-view-enter-key/) of people frustrated by the new behavior since it's been there for a very long time (ever?) and it works that way in every browser devtools. Hence, we should revert to the original behavior (pre Bug 1861674).
It's still nice to have the pref for people who want the new behavior

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1877457 - [devtools] Default devtools.inspector.rule-view.focusNextOnEnter to true. r=#devtools-reviewers.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1877457 - [devtools] Remove ruleview-kbd-enter-notice. r=#devtools-reviewers.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d511dc53852
[devtools] Default devtools.inspector.rule-view.focusNextOnEnter to true. r=devtools-reviewers,ochameau.
https://hg.mozilla.org/integration/autoland/rev/959c3318d5c3
[devtools] Remove ruleview-kbd-enter-notice. r=devtools-reviewers,ochameau.

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/7d511dc53852
https://hg.mozilla.org/mozilla-central/rev/959c3318d5c3

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1877457 - [devtools] Default devtools.inspector.rule-view.focusNextOnEnter to true. r=#devtools-reviewers.

Original Revision: https://phabricator.services.mozilla.com/D200159

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1877457 - [devtools] Remove ruleview-kbd-enter-notice. r=#devtools-reviewers.

Original Revision: https://phabricator.services.mozilla.com/D200160

Comment 7

[Phabricator Automation]

Uplift Approval Request

• Steps to reproduce for manual QE testing: -
• Risk associated with taking this patch: low
• Needs manual QE test: no
• User impact if declined: This rolls back a keyboard behavior change in the Inspector that people are really frustrated with, as it changes a very old, standard-wide, pattern. If declined, people might switch to other browser devtools to develop/debug their websites
• Fix verified in Nightly: no
• Code covered by automated testing: yes
• Explanation of risk level: devtools only, basically backs out changes that were made 2 versions ago
• Is Android affected?: no
• String changes made/needed: -

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1877457 - [devtools] Default devtools.inspector.rule-view.focusNextOnEnter to true. r=#devtools-reviewers.

Original Revision: https://phabricator.services.mozilla.com/D200159

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1877457 - [devtools] Remove ruleview-kbd-enter-notice. r=#devtools-reviewers.

Original Revision: https://phabricator.services.mozilla.com/D200160

Comment 10

[Phabricator Automation]

Uplift Approval Request

• String changes made/needed: -
• Is Android affected?: no
• Needs manual QE test: no
• Risk associated with taking this patch: low
• Steps to reproduce for manual QE testing: -
• Explanation of risk level: devtools only, basically backs out changes that were made 2 versions ago
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• User impact if declined: This rolls back a keyboard behavior change in the Inspector that people are really frustrated with, as it changes a very old, standard-wide, pattern. If declined, people might switch to other browser devtools to develop/debug their websites

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1877457 - [devtools] Default devtools.inspector.rule-view.focusNextOnEnter to true. .

Original Revision: https://phabricator.services.mozilla.com/D200159

Comment 12

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1877457 - [devtools] Remove ruleview-kbd-enter-notice. .

Original Revision: https://phabricator.services.mozilla.com/D200160

Comment 13

[Phabricator Automation]

Uplift Approval Request

• Code covered by automated testing: yes
• User impact if declined: This rolls back a keyboard behavior change in the Inspector that people are really frustrated with, as it changes a very old, browsers-wide, pattern. If declined, people might switch to other browser devtools to develop/debug their websites
• Fix verified in Nightly: no
• Explanation of risk level: devtools only, basically backs out changes that were made 2 versions ago
• Steps to reproduce for manual QE testing: -
• Needs manual QE test: no
• Risk associated with taking this patch: low
• Is Android affected?: no
• String changes made/needed: -

Comment 14

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1877457 - [devtools] Default devtools.inspector.rule-view.focusNextOnEnter to true. .

Original Revision: https://phabricator.services.mozilla.com/D200159

Comment 15

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1877457 - [devtools] Remove ruleview-kbd-enter-notice. .

Original Revision: https://phabricator.services.mozilla.com/D200160

Comment 16

[Phabricator Automation]

Uplift Approval Request

• Is Android affected?: no
• String changes made/needed: -
• Steps to reproduce for manual QE testing: -
• Needs manual QE test: no
• Risk associated with taking this patch: low
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• User impact if declined: This rolls back a keyboard behavior change in the Inspector that people are really frustrated with, as it changes a very old, browsers-wide, pattern. If declined, people might switch to other browser devtools to develop/debug their websites
• Explanation of risk level: devtools only, basically backs out changes that were made 2 versions ago

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/d1def5bacf6b
https://hg.mozilla.org/releases/mozilla-beta/rev/edd7d6c869f5

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/cd989e35e77b
https://hg.mozilla.org/releases/mozilla-release/rev/fbf48ecbc05f