1876801 - Restore AdditionalCTA link styles

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P3)

Description

[Emily McMinn :emcminn]

CSS specificity got a little tangled. This should restore the ability to apply text-link styles to additional_cta with "style": "link"

Comment 1

[Emily McMinn :emcminn]

Attachment: Bug 1876801 - Restore AdditionalCTA link styles

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1868494

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b284cb325eb
Restore AdditionalCTA link styles r=negin,aminomancer

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0b284cb325eb

Comment 5

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:emcminn, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Emily McMinn :emcminn]

Comment on attachment 9376710 [details]
Bug 1876801 - Restore AdditionalCTA link styles

Beta/Release Uplift Approval Request

• User impact if declined: Some onboarding messages will have elements styled as buttons when they should be styled as links; an upcoming Fx123 experiment will be affected
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Can be tested by pasting the following test message into the browser. "Show detailed information" should be styled as a link.

https://gist.github.com/AllegroFox/82d9aa9831a8d9a59005c90d60457d9b

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small CSS change
• String changes made/needed: none
• Is Android affected?: No

Comment 7

[Ciprian Georgiu, Desktop QA]

I have reproduced this issue with an affected Nightly build (2024-01-26), and by following STR from comment 6.

The issue is verified as fixed on latest Nightly 124.0a1 under macOS 13, Ubuntu 22.04 and Win 11.

Comment 8

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9376710 [details]
Bug 1876801 - Restore AdditionalCTA link styles

Approved for 123 beta 8, thanks.

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/fb1cdf89ba26

Comment 10

[Pascal Chevrel (relman team) -> :pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/fb1cdf89ba26

Comment 11

[Ciprian Georgiu, Desktop QA]

This is also verified as fixed on Beta 123.0b8 (treeherder build) with Win 11, Ubuntu 22.04 and macOS 14.