1868494 - [Feature Callout] Add support for a split button that opens a submenu

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Shane Hughes [:aminomancer]]

Add a split dismiss button that opens a submenu.

Comment 1

[Shane Hughes [:aminomancer]]

Attachment: Bug 1868494 - Feature Callouts to support button submenus. r=#omc-reviewers

Comment 2

[Shane Hughes [:aminomancer]]

Note: test message definition for the media add-ons so far...

{"id":"TEST_FEATURE_TOUR","template":"feature_callout","groups":[],"content":{"id":"TEST_FEATURE_TOUR","template":"multistage","backdrop":"transparent","transitions":false,"disableHistoryUpdates":true,"screens":[{"id":"FEATURE_CALLOUT_1","anchors":[{"selector":"#PanelUI-menu-button","panel_position":{"anchor_attachment":"bottomcenter","callout_attachment":"topright"}}],"content":{"position":"callout","title":{"raw":"Get more out of your media"},"title_logo":{"alignment":"top","height":"28px","width":"28px","marginInline":"4px 16px","imageURL":"@TODO - upload..."},"subtitle":{"raw":"Find the latest tools for image searching, audio improvements, and more.","paddingInline":"36px 0","marginBlock":"-4px 0"},"additional_button":{"label":{"raw":"Dismiss"},"action":{"navigate":true},"style":"secondary"},"secondary_button":{"label":{"raw":"Explore add-ons"},"action":{"navigate":true},"style":"primary"},"submenu_button":{"submenu":[{"type":"action","label":{"raw":"Don't show this recommendation again"},"action":{"navigate":true},"id":"item1"},{"type":"action","label":{"raw":"Show fewer media-related recommendations"},"action":{"navigate":true},"id":"item2"},{"type":"separator"},{"type":"action","label":{"raw":"Manage Settings"},"action":{"navigate":true},"id":"item3"}],"attached_to":"additional_button","style":"secondary"}}}]}}

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04752c78dfb0
Feature Callouts to support button submenus. r=omc-reviewers,jprickett

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/04752c78dfb0

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this task using the steps provided here and I can confirm the following:

• A feature callout containing a split "Advance" button is displayed after the "Show" button from the "TEST_FEATURE_TOUR" message is clicked.
• A dropdown menu containing options is displayed if the downward arrow button from the right click of the "Advance" button is clicked.
• The feature callout is dismissed if the "Advance" button or any option from the dropdown menu is clicked.

Verified using the latest Firefox Nightly 123.0a1 (Build ID: 20240108213208) installed on Windows 10 x64, macOS 14.1.1, and Ubuntu 22.04 x64.