1877002 - System theme not applied correctly

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Marco Maccaferri]

Attachment: firefox_titlebar_122.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0

Steps to reproduce:

Ubuntu 22.04
Firefox Snap
Yaru-remix theme (bright content with dark title bars).

Actual results:

The title bar colors are not applied correctly.
Possibly also other part of the UI are not correct (can't fully verify).

Expected results:

See screenshots for a comparison.

Comment 1

[Marco Maccaferri]

Attachment: firefox_titlebar_121.png

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Ah this would be a regression from bug 1869299, will take a look.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1877002 - Detect the yaru-remix theme, to avoid applying the yaru overrides there. r=stransky

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97de3c8a7931
Detect the yaru-remix theme, to avoid applying the yaru overrides there. r=stransky

Comment 6

[Bob Hood [:bhood]]

Emilio, could you please assign Priority/Severity ratings to this report when you get a chance?

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/97de3c8a7931

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9376913 [details]
Bug 1877002 - Detect the yaru-remix theme, to avoid applying the yaru overrides there. r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0 (needs a custom gtk theme)
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively simple patch.
• String changes made/needed: none
• Is Android affected?: No

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9376913 [details]
Bug 1877002 - Detect the yaru-remix theme, to avoid applying the yaru overrides there. r=stransky

Approved for 123 beta 5, thanks.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/262e39ec1473

Comment 12

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/262e39ec1473

Comment 13

[Donal Meehan [:dmeehan]]

:emilio what about adding a release uplift request on this?
We have a scheduled Fx122 dot release that builds on 2024-02-05. If this can be included or it should ride the train with Fx123.

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9376913 [details]
Bug 1877002 - Detect the yaru-remix theme, to avoid applying the yaru overrides there. r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: see above
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See above
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial patch.
• String changes made/needed: none
• Is Android affected?: No

Comment 15

[Daniel Bodea [:danibodea]]

I can't seem to reproduce your issue with Nightly v122.0a1 from 2023-12-13 or Beta v122.0b4 archive builds and neither in 122.0 (64-bit) Snap in Ubuntu 22. I've tested the issue using the following theme:
https://addons.mozilla.org/en-US/firefox/addon/ubuntu-yaru/?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=search

If a different theme reproduces this issue, please provide the exact one. Thank you!

Comment 16

[Marco Maccaferri]

I've installed everything a long time ago, hope to remember the steps.

First, Ubuntu 22.04 with the Yaru-remix installed in the user's .themes folder, if I remember correctly I extracted the content from a previous Ubuntu release (21.10 maybe) because Ubuntu dropped the Yaru-remix with 22.04 (not sure if this is relevant).

Installed yaru-remix-themes snap:
yaru-remix-themes 21.04.1 11 latest/stable muqtxdir-m -

Connected the firefox snap to the theme as posted here https://snapcraft.io/yaru-remix-themes
content[gtk-3-themes] firefox:gtk-3-themes yaru-remix-themes:gtk-3-themes manual
content[gtk-3-themes] snap-store:gtk-3-themes yaru-remix-themes:gtk-3-themes manual

Comment 17

[Daniel Bodea [:danibodea]]

I am unable to install the Yaru-remix theme because I do not have access to the themes folder (~/.themes (or) /usr/share/themes). All other install methods seem to fail. This being said, I cannot verify this fix on restricted systems.

Marco, Would you be able to confirm that your issue no longer occurs in the latest Nightly v124.0a1 and/or Beta v123.0b5 (or later builds)?
Thank you very much for your contribution!

Comment 18

[Marco Maccaferri]

Attachment: firefox_titlebar_123b5.png

Tried the beta 123.0b5, looks good to me.
Also tested switching themes and are applied correctly.

Thank you.

Comment 19

[Donal Meehan [:dmeehan]]

Comment on attachment 9376913 [details]
Bug 1877002 - Detect the yaru-remix theme, to avoid applying the yaru overrides there. r=stransky

Approved for 122.0.1

Comment 20

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/7704af6674ab

Comment 21

[Daniel Bodea [:danibodea]]

Setting 123 branch as verified based on comment 18.

Comment 22

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue on Ubuntu 22.04 with Firefox 122.0 Snap package by using the Yaru-remix theme installed inside Gnome Tweaks and then following this tutorial: https://store.kde.org/p/1384810. After activating the Yaru-remix theme on Snap using the commands from the comment 16 link the Firefox Snap will have a white tab bar instead of a dark one and browser buttons will be barely visible.
The issue is verified fixed on Ubuntu 22.04 and Ubuntu 20.04 with Firefox Snap 122.0.1, 123.0b6 and 124.0a1 (2023-02-05). The Yaru-remix theme is correctly applied for the tab bar.