1877191 - Add skipPermitUnload parameter to ContextualIdentityService.closeContainerTabs

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P3)

Description

[Julian Descottes [:jdescottes]]

We should expose an option to skip before unload prompts in ContextualIdentityService.closeContainerTabs and forward it to tabbrowser.removeTab

Comment 1

[Daniel Veditz [:dveditz]]

If this bug is moved to our component, could you explain a bit more what you want to happen?

Comment 2

[Julian Descottes [:jdescottes]]

Sure. In the WebDriver BiDi spec, when removing a user context we should close all related browsing contexts and skip any potential before unload prompt.

To close the tabs we use closeContainerTabs, which relies on tabbrowser.removeTab. removeTab supports a skipPermitUnload option, so the idea would be to add a skipPermitUnload parameter to closeContainerTabs and forward it to removeTab. So something like:

  closeContainerTabs(userContextId = 0, skipPermitUnload=false) {
    return new Promise(resolve => {
      let remoteTabIds = new Set();
      this._forEachContainerTab((tab, tabbrowser) => {
        let frameLoader = tab.linkedBrowser.frameLoader;

        // We don't have remoteTab in non-e10s mode.
        if (frameLoader.remoteTab) {
          remoteTabIds.add(frameLoader.remoteTab.tabId);
        }

        tabbrowser.removeTab(tab, { skipPermitUnload });
      }, userContextId);

      if (remoteTabIds.size == 0) {
        resolve();
        return;
      }

      new _TabRemovalObserver(resolve, remoteTabIds);
    });
  },

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1877191 - Add removeTabOptions parameter to ContextualIdentityService.closeContainerTabs

Adds a removeTabOptions optional parameter to closeContainerTabs that will be forwarded to tabbrowser.removeTab
This allows to set options such as skipPermitUnload.
Browser mochitest added to check the new behavior. This should be a noop for current consumers of the API.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c4672e11b77
Add removeTabOptions parameter to ContextualIdentityService.closeContainerTabs r=mconley

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/1c4672e11b77