1876062 - Skip "beforeunload" prompts when closing tabs during browser.removeUserContext

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Julian Descottes [:jdescottes]]

Per spec, we should skip beforeunload prompts when closing container tabs. We should be able to expose the skipPermitUnload argument of tabbrowser removeTab via ContextualIdentityService.closeContainerTabs.

However to test this properly we need first to allow beforeunload prompts not to be skipped.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We have to wait for bug 1824220 which will add more capability handling to be able at all to work with this kind of user prompt.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1876062 - [webdriver-bidi] Skip "beforeunload" prompts when closing tabs in "browser.removeUserContext".

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1876062 - [wdspec] Add test for skipping "beforeunload" prompts for "browser.removeUserContext".

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6598932efaa
[webdriver-bidi] Skip "beforeunload" prompts when closing tabs in "browser.removeUserContext". r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/e08c61b4cc4a
[wdspec] Add test for skipping "beforeunload" prompts for "browser.removeUserContext". r=webdriver-reviewers,Sasha

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46811 for changes under testing/web-platform/tests

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c6598932efaa
https://hg.mozilla.org/mozilla-central/rev/e08c61b4cc4a

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot