1877221 - Update vendored ffmpeg library to current tip

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1877221 - Add new symbols and defines needed for current ffmpeg to build. r?#media-playback-reviewers

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1877221 - Adjust moz.build for new ffmpeg version. r?#media-playback-reviewers

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1877221 - Pull in new ffmpeg code, reapply patch. r?#media-playback-reviewers

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1877221 - Slightly adjust threshold in oscillator and compressor test in WPT for new FFT code. r?pehrsons

The compressor test makes use of a sawtooth wave and was already failing -- this is
simply adjusting the expected error.

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1877221 - Clamp rolloff factor appropriately in PannerNodeEngine. r?pehrsons

https://webaudio.github.io/web-audio-api/#dom-pannernode-rollofffactor

I mistook this as a fallout of the new FFT code, and saw the fix was trivial
when understood that it was an existing failure.

This includes a drive-by fix for a warning.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c6bc24640ef
Add new symbols and defines needed for current ffmpeg to build. r=media-playback-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/c5920de78d16
Adjust moz.build for new ffmpeg version. r=media-playback-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/186e2a334f2d
Pull in new ffmpeg code, reapply patch. r=media-playback-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/087f8190230d
Slightly adjust threshold in oscillator and compressor test in WPT for new FFT code. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/7572eb3fac37
Clamp rolloff factor appropriately in PannerNodeEngine. r=pehrsons

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44474 for changes under testing/web-platform/tests

Comment 8

[Paul Adenot (:padenot)]

Attachment: Bug 1877221 - Remove ARMv7 files related to obsolete FFT code in FFmpeg.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76fe3142049b
Remove ARMv7 files related to obsolete FFT code in FFmpeg.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a772caee48aa
Remove one more file related to obsolete ffmpeg FFT code.

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5c6bc24640ef
https://hg.mozilla.org/mozilla-central/rev/c5920de78d16
https://hg.mozilla.org/mozilla-central/rev/186e2a334f2d
https://hg.mozilla.org/mozilla-central/rev/087f8190230d
https://hg.mozilla.org/mozilla-central/rev/7572eb3fac37
https://hg.mozilla.org/mozilla-central/rev/76fe3142049b
https://hg.mozilla.org/mozilla-central/rev/a772caee48aa

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 14

[Mayank Bansal]

(either this bug or bug 1876526 led to improvement):
13% improvement on AWFY-Webaudio-Convolution reverb