1879740 - Crash in [@ google_breakpad::ExceptionHandler::HandleInvalidParameter]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

10 crashes from 3 installations of Firefox 124.0a1 on Windows 10, first affected build ID is 20240209114116 - the first build with the changes from bug 1877221.

Crash report: https://crash-stats.mozilla.org/report/index/73b3604e-14af-4174-9357-46d200240210

Reason: STATUS_INVALID_PARAMETER

Top 10 frames of crashing thread:

0  xul.dll  google_breakpad::ExceptionHandler::HandleInvalidParameter  toolkit/crashreporter/breakpad-client/windows/handler/exception_handler.cc:613
1  ucrtbase.dll  invalid_parameter  
2  ucrtbase.dll  invalid_parameter_noinfo  
3  ucrtbase.dll  __crt_stdio_output::output_processor<char, __crt_stdio_output::string_output_adapter<char>, __crt_stdio_output::standard_base<char, __crt_stdio_output::string_output_adapter<char> > >::process  
4  ucrtbase.dll  common_vsprintf<__crt_stdio_output::standard_base, char>  
5  mozavutil.dll  vsnprintf  /builds/worker/fetches/vs/Windows Kits/10/Include/10.0.19041.0/ucrt/stdio.h:1439
5  mozavutil.dll  av_bprintf  media/ffvpx/libavutil/bprint.c:110
6  mozavutil.dll  print_cd_info  media/ffvpx/libavutil/tx.c:611
7  mozavutil.dll  ff_tx_init_subtx  media/ffvpx/libavutil/tx.c:823
8  mozavutil.dll  av_tx_init  media/ffvpx/libavutil/tx.c:922

Comment 1

[Gabriele Svelto [:gsvelto]]

Added a crash signature.

Comment 2

[Paul Adenot (:padenot)]

This happens because ffmpeg is passing an unicode character to a stdio.h function (vsnprintf) on Windows 10 pre-2018, and because we're probably not doing this: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/setlocale-wsetlocale?view=msvc-170#utf-8-support.

I'm just going to sidestep this, we don't need this log.

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1879740 - Remove moz.build file that should have been removed in bug 1875201. r?mjf

Comment 4

[Phabricator Automation]

Comment on attachment 9379724 [details]
Bug 1879740 - Remove moz.build file that should have been removed in bug 1875201. r?mjf

Revision D201595 was moved to bug 1879898. Setting attachment 9379724 [details] to obsolete.

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1879740 - Don't pass an UTF-8 string to system vsnprintf. r?#media-playback-reviewers

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 desktop browser crashes on nightly

For more information, please visit BugBot documentation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32f7037461f2
Don't pass an UTF-8 string to system vsnprintf. r=media-playback-reviewers,chunmin

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/32f7037461f2