1877295 - Investigate option to return to first-run onboarding at a later time

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Comment 1

[Emily McMinn :emcminn]

Attachment: WIP: Bug 1877295 - Toolbar button option for returning to about:welcome

Comment 2

[Emily McMinn :emcminn]

Attachment: Bug 1877295 - Toolbar button option for returning to about:welcome

Comment 3

[Emily McMinn :emcminn]

Attachment: WIP: Bug 1877295 - Testing review feedback

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4aafa3f8df2d
Toolbar button option for returning to about:welcome r=pdahiya,fluent-reviewers,Gijs,desktop-theme-reviewers,omc-reviewers,bolsson

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_preferences_usage.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_preferences_usage.js | browser.startup.record should be accessed at most 400 times. - 401 <= 400 - {"filename":"chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js","name":"checkPrefGetters","sourceId":637,"lineNumber":63,"columnNumber":16,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://moch

Comment 6

[Emily McMinn :emcminn]

Pretty sure this is caused by checking lazy.AWToolbarButton.hasToolbarButtonEnabled before Cu.isInAutomation inside BrowserGlue; which would cause the AWToolbarButton module to load in the test env. I've just inverted the check so that we check for the test environment first, which should prevent browser.startup.record from getting triggered in the test environment.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4367b1826eb
Toolbar button option for returning to about:welcome r=pdahiya,fluent-reviewers,Gijs,desktop-theme-reviewers,omc-reviewers,bolsson,firefox-desktop-core-reviewers ,mossop

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f4367b1826eb

Comment 9

[Meg Viar [:mviar]]

:emcminn, :gijs pointed me to the browser.ui.customizable_ui probes that cover a number of widget actions including adding and removing. See recordWidgetChange.