1877298 - Create reusable token for colors used in the tab "attention" radial gradient

Status: RESOLVED FIXED

(Firefox :: Theme, task, P1)

Description

[Kelly Cochrane [:kcochrane]]

Attachment: Screenshot 2024-01-29 at 4.52.55 PM.png

The colors used here for when a tab has "attention" will also be needed in Firefox View as we're adding tab indicators in Firefox View. It'd be nice to have these available as a reusable token.

Comment 1

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1877298 - Create reusable token for color used in the tab attention radial gradient. r=jules,dao,kcochrane

Comment 2

[Sarah Clements [:sclements] | PTO until March 30th]

I'm thinking we can address bug 1884351 as part of this work.

Comment 3

[Kelly Cochrane [:kcochrane]]

Gonna let :emilio take this over as I have higher priority work to look at currently (also because I don't have a way to test this on Linux). Thanks, Emilio! Feel free to commandeer my existing patch.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1877298 - Make contentTheme.js propagate whether there's a lwtheme. r=dao

Also, while at it, use consistent naming for "active" vs. "hasTheme", which are
the same.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1877298 - Make tab color in firefox view match the browser UI on Linux and prefers-contrast modes. r=dao,kcochrane

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/478cc456a4c7
Create reusable token for color used in the tab attention radial gradient. r=desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,jules,dao,kcochrane
https://hg.mozilla.org/integration/autoland/rev/a2d9c41987af
Make contentTheme.js propagate whether there's a lwtheme. r=dao

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00bdcc4c5a6b
Simplify a test that I just added that doesn't pass consistently on Windows.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc2ecec6507b
Fix lint failure in browser_ext_themes_ntp_colors.js r=fix CLOSED TREE

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf6cb00255bb
Fix browser_ext_themes_ntp_colors.js to be more reliable.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4c92c130473
Fix lint failure. CLOSED TREE

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/478cc456a4c7
https://hg.mozilla.org/mozilla-central/rev/a2d9c41987af
https://hg.mozilla.org/mozilla-central/rev/00bdcc4c5a6b
https://hg.mozilla.org/mozilla-central/rev/bc2ecec6507b

Comment 12

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/bf6cb00255bb
https://hg.mozilla.org/mozilla-central/rev/c4c92c130473

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/634686426eb7
Make tab color in firefox view match the browser UI on Linux and prefers-contrast modes. r=dao,kcochrane,desktop-theme-reviewers,fxview-reviewers,jules

Comment 14

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/634686426eb7