1877416 - Firefox is installing components needed to play the audio or video on this page message is displayed three times

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Found in

• 123.0b4

Affected versions

• 124.0a1 (2024-01-26)
• 123.0b4

Tested platforms

• Affected platforms: Windows 10x64, macOS 12, Lubuntu 22.04
• Unaffected platforms: none

Preconditions

• New profile

Steps to reproduce

1. Open https://edition.cnn.com/

Expected result

• Firefox is installing components needed to play the audio or video on this page message is displayed one time

Actual result

• Firefox is installing components needed to play the audio or video on this page message is displayed three times

Regression

• Mozregression pushlog:
  Last good revision: 350fac42df08982dcb6992f3ab5c733a119bce8f
  3:41.64 INFO: First bad revision: fe54bf7adef07c981ea02056742b1b7997a27d55
  3:41.64 INFO: Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=350fac42df08982dcb6992f3ab5c733a119bce8f&tochange=fe54bf7adef07c981ea02056742b1b7997a27d55

Additional notes

• Attached a screenshot.
• On Lubuntu 22 the Enable DRM message is displayed three times.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:hjones, since you are the author of the regressor, bug 1845150, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Hanna Jones [:hjones]]

Attachment: Bug 1877416 - handle reentrancy when showing infobars via EncryptedMediaParent.receiveMessage r=#recomp-reviewers,tgiles,mstriemer

notificationBox.appendNotification is now async, so in cases where we were receiving multiple "cdm-not-installed" messages in quick succession it was possible that the notification from the prior call hadn't actully been appended yet. This made it so that calls to notificationBox.getNotificationWithValue wouldn't return anything, and we would show the same message multiple times. This patch adds code to track which notification related messages are being handled to avoid re-appending the same notification.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ba8a1897af6
handle reentrancy when showing infobars via EncryptedMediaParent.receiveMessage r=reusable-components-reviewers,tgiles

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/1ba8a1897af6

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:hjones, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with 124.0a1 (20240202094312) on Windows 11x64, macOS 12 and Ubunut 22. Only one message is displayed as expected after following steps from comment 0.

Comment 8

[Hanna Jones [:hjones]]

Attachment: Bug 1877416 - handle reentrancy when showing infobars via EncryptedMediaParent.receiveMessage r=#recomp-reviewers,tgiles,mstriemer

notificationBox.appendNotification is now async, so in cases where we were receiving multiple "cdm-not-installed" messages in quick succession it was possible that the notification from the prior call hadn't actully been appended yet. This made it so that calls to notificationBox.getNotificationWithValue wouldn't return anything, and we would show the same message multiple times. This patch adds code to track which notification related messages are being handled to avoid re-appending the same notification.

Original Revision: https://phabricator.services.mozilla.com/D200030

Comment 9

[Phabricator Automation]

Uplift Approval Request

• Steps to reproduce for manual QE testing: Open https://edition.cnn.com/ and verify that the message bar shows only once (if at all - may need a fresh profile or build to ensure the plugin isn't already installed)
• Is Android affected?: no
• String changes made/needed: No
• Needs manual QE test: no
• Explanation of risk level: It's fixing a bug, and that bug isn't relevant on the vast majority of websites
• Code covered by automated testing: yes
• User impact if declined: Two bugs were filed for this in nightly, so it's likely more people will notice on release
• Fix verified in Nightly: yes
• Risk associated with taking this patch: Low

Comment 10

[Hanna Jones [:hjones]]

I've requested uplift to beta: https://phabricator.services.mozilla.com/D200854

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/945276c7a9a1

Comment 12

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 123.0b8 on Windows 11 x64, macOS 12 and Ubuntu 22. Only one message is displayed as expected after following steps from comment 0.