1877438 - "network.fetchError" event is not sent when "fetch" request gets immediately aborted

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

There is the following Puppeteer test which loads a page and triggers a fetch request by clicking a button:
https://github.com/puppeteer/puppeteer/blob/b99d478cd48adc261878836e04eac55ecc2890f2/test/src/page.spec.ts#L921-L935
https://github.com/puppeteer/puppeteer/blob/main/test/assets/abort-request.html

Hereby the fetch request gets immediately aborted via an AbortController. When using Chrome the network.fetchError event is correctly sent out but in Firefox we only raise a log.entryAdded error for the abort() call. I recorded a Gecko Profile for this test and as it looks like this specific network request still awaits a response.

https://share.firefox.dev/3Shy0bd

Not sure if that is related to some of our code or at the network layer.

Comment 1

[Julian Descottes [:jdescottes]]

Requests which are blocked really do not receive further updates after the creation of the network event. DevTools handles this use case specifically at https://searchfox.org/mozilla-central/rev/896042a1a71066254ceb5291f016ca3dbca21cb7/devtools/server/actors/resources/network-events.js#318-325

We can probably do the same in NetworkEventRecord.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1877438 - [bidi] Emit fetchError event for requests blocked early

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1877438 - [wdspec] Add test for early fetchError events

Depends on D200873

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/709e6b31df0f
[bidi] Emit fetchError event for requests blocked early r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/bd25bd316fa4
[wdspec] Add test for early fetchError events r=webdriver-reviewers,whimboo

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44485 for changes under testing/web-platform/tests

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/709e6b31df0f
https://hg.mozilla.org/mozilla-central/rev/bd25bd316fa4

Comment 7

[Julian Descottes [:jdescottes]]

Reminder to move https://github.com/puppeteer/puppeteer/pull/11867 out of draft status when the patch is in Nightly.

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot