1877534 - `make run` stdout is very spammy

Status: RESOLVED FIXED

(Tecken :: General, defect, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Since we adjusted the docker-compose.yaml file to better implement health checks for backing services, when we do make run which does:

docker-compose up web frontend fakesentry

it brings up all the depends_on services as attached. That means we see tons of output from statsd, db, localstack, gcp-emulator, and all their rowdy drunken friends.

In order to be able to see the output from web, fakesentry, and frontend, we need to quell their raucous crosstalk.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'm pretty sure we can mark which services are started as detached and that'll fix it. I'm going to try that.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: [mozilla-services/tecken] bug 1877534: mark backing services with --no-attach (#2886)

Comment 3

[Daniel Thorn [:relud]]

on docker desktop for mac 4.26.1 i am only being attached to the explicitly listed services web frontend fakesentry

Comment 4

[Daniel Thorn [:relud]]

i am also not being attached to any unspecified services on ubuntu

Comment 5

[Daniel Thorn [:relud]]

what i am getting is lines like this from fakesentry in response to the health check:

fakesentry-1  | [2024-01-30 22:26:47,619] INFO: _internal: 127.0.0.1 - - [30/Jan/2024 22:26:47] "GET / HTTP/1.1" 200 -

but that isn't helped by https://github.com/mozilla-services/tecken/pull/2886

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

I've got Ubuntu 23.10 using the docker.io packages:

$ docker version
Client: Docker Engine - Community
 Version:           24.0.5
 API version:       1.43
 Go version:        go1.20.6
 Git commit:        ced0996
 Built:             Fri Jul 21 20:35:24 2023
 OS/Arch:           linux/amd64
 Context:           default

Server: Docker Engine - Community
 Engine:
  Version:          24.0.5
  API version:      1.43 (minimum version 1.12)
  Go version:       go1.20.6
  Git commit:       a61e2b4
  Built:            Fri Jul 21 20:35:24 2023
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.21
  GitCommit:        3dce8eb055cbb6872793272b4f20ed16117344f8
 runc:
  Version:          1.1.7
  GitCommit:        v1.1.7-0-g860f061
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

It can reproduce the problem regularly:

1. docker compose stop to shut everything down
2. ./slick.sh to start backing services and set everything up
3. make run to run things

Then the backing services are spitting lots of output to stdout.

I looked through the docker compose issue tracker and don't see anything that sounds like this issue. There are some version differences between what Relud has on their Ubuntu setup and what I've got, but nothing that strikes me as fishy. I'm completely stumped as to why I'm having this problem.

I'll adjust fakesentry healthcheck interval to reduce that, too.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

I tried to adjust the fakesentry healtcheck and failed spectacularly. If I adjust the interval to, say, 30s, then it takes 30s before the web service comes up. That stinks.

I wrote up an issue in kent to fix logging. https://github.com/willkg/kent/issues/69

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR [mozilla-services/tecken]: bug 1877534: mark backing services with --no-attach (#2886) in ca89122.

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: [mozilla-services/tecken] bug-1877534: upgrade Kent to 1.2.0 (#2887)

Comment 10

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR [mozilla-services/tecken]: bug-1877534: upgrade Kent to 1.2.0 (#2887) in f299da3.

Comment 11

[Daniel Thorn [:relud]]

Attachment: [mozilla-services/tecken] bug 1877534: use --attach-dependencies=false instead of --no-attach (#2890)

Comment 12

[Daniel Thorn [:relud]]

relud merged PR [mozilla-services/tecken]: bug 1877534: use --attach instead of --no-attach (#2890) in 9e2449d.

Comment 13

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was deployed just now in bug #1880345 in v2024.02.14. Marking as FIXED.