Closed
Bug 1877536
Opened 5 months ago
Closed 4 months ago
Update RemoteSettingsConfig call for new parameter order
Categories
(Firefox :: Address Bar, task, P1)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox124 | --- | fixed |
People
(Reporter: adw, Unassigned)
References
Details
A few days ago the order of the RemoteSettingsConfig()
params was changed. Once that revision is vendored into m-c, we'll need to update SuggestBackendRust. In the meantime, if you're testing a vendoring locally, you'll need to update the backend because otherwise you'll get an unhelpful generic "Error initializing SuggestStore" error.
The new ordering is: collection, bucket, server -- as below:
new lazy.RemoteSettingsConfig(
"quicksuggest",
lazy.Utils.actualBucketName("main"),
lazy.Utils.SERVER_URL
)
Reporter | ||
Comment 1•5 months ago
|
||
QuickSuggestTestUtils needs updating too.
Comment 2•5 months ago
|
||
See also bug 1875848 - if we can get that in, this will not be necessary.
Reporter | ||
Comment 3•5 months ago
|
||
Thanks Mark, your WIP patch in that bug looks great, it'll be a nice ergonomic improvement for sure.
See Also: → 1875848
Reporter | ||
Comment 4•4 months ago
|
||
This landed as part of the vendor in bug 1878987 because otherwise tests would have broken.
Status: NEW → RESOLVED
Closed: 4 months ago
status-firefox124:
--- → fixed
Depends on: 1878987
Resolution: --- → FIXED
Version: unspecified → Firefox 124
You need to log in
before you can comment on or make changes to this bug.
Description
•