Open Bug 1877854 Opened 2 years ago Updated 2 years ago

[RTL] Arrows in the open tabs "more" menu are pointing in the wrong direction

Categories

(Firefox :: Firefox View, defect, P3)

defect

Tracking

()

People

(Reporter: itiel_yn8, Unassigned)

References

Details

(Whiteboard: [fidefe-firefox-view])

Specifically, this:
https://searchfox.org/mozilla-central/rev/6e2e933cd6b7931e1d4e8bd8af8daa9788b27760/toolkit/content/widgets/panel-list/panel-item.css#89-91
should be working, but it isn't.
Curiously, if I change the rtl to ltr it starts working, even though the document is most certainly RTL. Is it because it's in the shadow root or something?

Huh, actually, this happens only in the first visit in about:firefoxview in a session.
After reloading the page the arrows point in the right direction. The issue gets back after the next restart.

Severity: -- → S4
Priority: -- → P3
Whiteboard: [fidefe-firefox-view]

Itiel, is this only happening in the submenu/fly-out menu? Hanna, any idea why this might be happening?

This bug might belong in the toolkit:widgets component since that's where this bit of code lives.

Flags: needinfo?(hjones)

I'm not seeing this (or something eimilar) anywhere else in Firefox View.

I went down a bit of a rabbit hole with this one and I don't think it's an issue with the panel-list itself. I ended up adding a story for panel-list submenus in Bug 1880481. You can pull that code down locally and use the pseudo localization switcher in storybook (button in the sb toolbar with <-- arrows) to switch between LTR and RTL. The icon direction seems to update as expected.

Just to be extra sure I added a submenu to about:preferences and played around with the browser toolbox bidi locale there + in Fxview. I could only replicate this issue in Fxview, not in about:preferences. If there's nothing unusual about how the document direction is getting set in view then feel free to kick this over to UI widgets and we can take another look.

Flags: needinfo?(hjones)
You need to log in before you can comment on or make changes to this bug.